MAAS errors on formatting micron disks if nvme command returns non-standard characters

[Grant Byrne]

When doing a format of the disk, MAAS runs ./maas_wipe.py

For us, it was producing the following error:

Traceback (most recent call last):
  File "/home/ubuntu/./maas_wipe.py", line 575, in <module>
    main()
  File "/home/ubuntu/./maas_wipe.py", line 555, in main
    disk_info = get_disk_info()
  File "/home/ubuntu/./maas_wipe.py", line 198, in get_disk_info
    return {kname: get_disk_security_info(kname) for kname in list_disks()}
  File "/home/ubuntu/./maas_wipe.py", line 198, in <dictcomp>
    return {kname: get_disk_security_info(kname) for kname in list_disks()}
  File "/home/ubuntu/./maas_wipe.py", line 191, in get_disk_security_info
    return get_nvme_security_info(disk)
  File "/home/ubuntu/./maas_wipe.py", line 97, in get_nvme_security_info
    output = output.decode()
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xfc in position 392: invalid start byte

The underlying issue was that it was failing to decode the output of the "nvme" command. In our case when we ran the following command in the ephemeral OS: sudo nvme id-ctrl /dev/nvme1n1

It returned the line: fguid : :8w�

The non-standard character at the end is causing the error on the line:
     output = output.decode()

The fix that we've come up with is to change the line to this:
     output = output.decode(encoding="ISO-8859-1")

I'd like to find a way to apply this patch because we're running into the issue pretty frequently when we upgrade the firmware on our Micron disks.

[maasuser1 (maasuser1)]

Same problem to this bug report?
https://bugs.launchpad.net/ubuntu/+source/nvme-cli/+bug/2051299

[Grant Byrne (grantbyrne)]

That looks like that is exactly the same issue. We'll try updating to Ubuntu 24.04 to see if it fixes the issue.