allow_dns accepts boolean instead of Int in the help
Bug #2044396 reported by
Nobuto Murata
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Low
|
Javier Fuentes |
Bug Description
maas: 1:3.4.0-
The help describes allow_dns accepts Int, but it only accepts boolean.
$ maas admin subnet update -h
...
:param allow_dns: Optional. Configure MAAS DNS to allow
DNS resolution from this subnet. '0' == False,'1' == True.
:type allow_dns: Int
$ maas admin subnet update 5 allow_dns=0
-> allow_dns is still true
$ maas admin subnet update 5 allow_dns=false
-> allow_dns will be false
"gateway_ip": "",
"dns_servers": [],
"allow_dns": false,
Related branches
~javier-fs/maas:2044396_allow_dns_for_bool_and_int
Merged
into
maas:master
- Stamatis Katsaounis: Approve
- MAAS Lander: Approve
-
Diff: 163 lines (+68/-13)3 files modifiedsrc/maasserver/api/subnets.py (+4/-4)
src/maasserver/api/tests/test_subnets.py (+57/-0)
src/maasserver/forms/subnet.py (+7/-9)
Changed in maas: | |
status: | New → Triaged |
importance: | Undecided → Medium |
importance: | Medium → Low |
milestone: | none → 3.5.0 |
Changed in maas: | |
assignee: | nobody → Javier Fuentes (javier-fs) |
Changed in maas: | |
status: | Triaged → In Progress |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
milestone: | 3.5.0 → 3.5.0-beta1 |
status: | Fix Committed → Fix Released |
To post a comment you must log in.