MAAS config option for IPMI cipher suite ID is not passed to bmc-config script

[Mauricio Faria de Oliveira]

The MAAS config option `maas_auto_ipmi_cipher_suite_id` is ignored.

It should be passed as an argument to the bmc-config script as the other `maas_auto_ipmi_...` options.

This is becoming increasingly important as some systems vendors
have been moving away from cipher suite ID 3 to 17 (usually),
or at least no longer offering 3 based on security profiles.

Tested on 3.4.0~rc2.
MR with the fix is linked.

[Mauricio Faria de Oliveira (mfo)]

By the way, slightly (un)related, MAAS versions older than 3.4
would also need backports of this commit (happy to send them!):

commit a2d011b8710894a40b5f02fbb12e641388f6be5a
Author: Eline Maaike de Weerd <email address hidden>
Date: Mon Jun 12 16:13:49 2023 +0000

    Added an e to the suit

diff --git a/src/maasserver/forms/parameters.py b/src/maasserver/forms/parameters.py
index 6d6715e7284e..25425c7a5f70 100644
--- a/src/maasserver/forms/parameters.py
+++ b/src/maasserver/forms/parameters.py
@@ -26,7 +26,7 @@ DEFAULTS_FROM_MAAS_CONFIG = {
     "maas_auto_ipmi_user",
     "maas_auto_ipmi_user_privilege_level",
     "maas_auto_ipmi_k_g_bmc_key",
- "maas_auto_ipmi_cipher_suit_id",
+ "maas_auto_ipmi_cipher_suite_id",
 }

$ git describe --contains a2d011b8710894a40b5f02fbb12e641388f6be5a
3.4.0-rc1~49

[Anton Troyanov (troyanov)]

Hi Mauricio,

Thanks for the bug report and the fix.

I will take care of backporting it (+ a2d011b8710894a40b5f02fbb12e641388f6be5a) to 3.3

[Mauricio Faria de Oliveira (mfo)]

Thanks, Anton!