Impossible to provide keyring file via UI when using custom image source

Bug #2012627 reported by Igor Brovtsin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Triaged
Low
Unassigned
maas-ui
Triaged
Low
Unassigned

Bug Description

In the "Choose [image] source" dialog, "Keyring data" field under advanced options is treated by MAAS as the actual kerying file content (== raw bytes without any encoding). This prevents users from adding signed custom image sources in UI without having to upload the keyring file to the region controller first.

There are multiple fixes that could be implemented:

1. Change the type of the field in MAAS UI, change the backend handling accordingly (if necessary at all: the current implementation simply dumps the contents of this field to the keyring file that then is used with `gpgv`).

2. Treat input as base64, decoding it before dumping the contents. Probably a viable solution, but seems more complicated from the user experience perspective (one should generate keyring file, then base64-encode it and then copy-and-paste it to the UI). Beware that CLI might be affected by the changes.

3. Ask for armor-exported keys instead of a keyring file. Simpler to validate, but adds more moving parts (MAAS will have to handle kerying generation on its own)

4. Get rid of keyring-related fields, asking whether the user trusts keys that were used to sign simplestreams contents. Very complicated to implement properly.

Revision history for this message
Igor Brovtsin (igor-brovtsin) wrote :

Also, the current field description is somewhat misleading

Changed in maas:
importance: Undecided → Low
Revision history for this message
Adam Collard (adam-collard) wrote :

We shouldn't have the keyring field point to a file on disk, since it doesn't work well with an HA deployment or a mix of snap/deb etc.

Changing the UI to use a file upload widget instead makes more sense.

Changed in maas:
assignee: Igor Brovtsin (igor-brovtsin) → nobody
milestone: none → 3.5.0
Changed in maas-ui:
status: New → Triaged
milestone: none → 3.5.0
importance: Undecided → Low
Changed in maas:
milestone: 3.5.0 → 3.5.x
Changed in maas-ui:
milestone: 3.5.0 → 3.5.x
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.