Missing foreign key constraints for Node.current_testing_script_set and friends

[Björn Tillenius]

The 'current_commissioning_script_set', 'current_testing_script_set' and 'current_commissioning_script_set' are declared like this in Node:

    current_testing_script_set = ForeignKey(
        "metadataserver.ScriptSet",
        blank=True,
        null=True,
        on_delete=SET_NULL,
        related_name="+",
    )

But if you look in the database, there's no FOREIGN KEY constraint for that column.

Further more, it seems like the 'on_delete=SET_NULL' also doesn't work properly. Node.start() eventually triggers ScriptResult.create_installation_script_set(), which triggers ScriptResult._clean_old(), which deletes all empty script sets. If one of those are the 'current' scriptset for a node, the Node attribute doesn't get set to None. Instead it leaves a dangling reference to a non-existing script set.

See bug 1996074 for an example where this caused a problem.

[Björn Tillenius (bjornt)]

By the looks of this, this is not trivial to fix. I'll take a stab at it on Tuesday. If I'm not able to do it then, I'll push it to 3.4.

[Björn Tillenius (bjornt)]

I have a fix for this, but will land it after we release 3.3