Owner data websocket methods are not working
Bug #1908356 reported by
Caleb Ellis
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
High
|
Dougal Matthews |
Bug Description
The "get_owner_data" and "set_owner_data" websocket methods have not been included in the list of allowed methods for machines, so they can't be done from the client.
Also, I think it'd be nicer if we just added a field on the machine object directly (something like machine.owner_data) so we don't have to keep calling "get_owner_data" every time we navigate somewhere it's needed.
Related branches
~d0ugal/maas:machine-list-owner-data
Rejected
for merging
into
maas:master
- MAAS Lander: Needs Fixing
- Björn Tillenius: Approve
-
Diff: 103 lines (+13/-6)3 files modifiedsrc/maasserver/websockets/handlers/machine.py (+3/-0)
src/maasserver/websockets/handlers/tests/test_controller.py (+2/-2)
src/maasserver/websockets/handlers/tests/test_machine.py (+8/-4)
~d0ugal/maas:allow-owner-data-methods
Merged
into
maas:master
- MAAS Lander: Approve
- Adam Collard (community): Approve
-
Diff: 13 lines (+2/-0)1 file modifiedsrc/maasserver/websockets/handlers/machine.py (+2/-0)
tags: | added: blocking-ui |
Changed in maas: | |
milestone: | 3.0.0 → 3.0-beta1 |
Changed in maas: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
I have added the methods to allowed_methods in the above branch. That should be landing soon.
> Also, I think it'd be nicer if we just added a field on the machine object directly (something like machine.owner_data) so we don't have to keep calling "get_owner_data" every time we navigate somewhere it's needed.
This was considered but since it wont be displayed by default in many places I think the overhead could be too high. However, I agree this would be a sensible change if it is a problem for the UI.