maas-ui Makefile does not detect source changes to trigger rebuild

Bug #1878124 reported by Lee Trager
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Triaged
Low
Unassigned
3.4
Won't Fix
Low
Unassigned

Bug Description

I reported a couple of UI bugs that ended up being fixed in the UI already. The reason the UI never updated for me is that the Makefile does not detect changes to the UI. I suspect this works when building the Snap because a clean environment is used every time. This is not the case when building development Debian packages.

Reproduction:
1. Build the UI
   cd src/maasui
   make
2. Make any edit to the UI
   rm src/ui/src/*.js
3. Use the Makefile to rebuild, you'll see the following
   make
   yarn --cwd src copy-build
   yarn run v1.19.1
   $ mkdir -p build/legacy build/ui && cp -R legacy/build/* build/legacy/ && cp -R ui/build/* build/ui/
Done in 0.06s

Either the Makefile/yarn should be modified to be able to recognize changes or the Makefile should be modified to rebuild whenever called.

tags: removed: ui
Changed in maas:
status: New → Triaged
importance: Undecided → Low
Revision history for this message
Adam Collard (adam-collard) wrote :

Does this still happen with the recent changes to the Makefile?

Changed in maas:
status: Triaged → Incomplete
milestone: none → 3.4.0
status: Incomplete → Triaged
Alberto Donato (ack)
Changed in maas:
milestone: 3.4.0 → 3.4.x
Changed in maas:
milestone: 3.4.x → 3.5.x
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.