[websocket-api] User first_name is unused and should not be returned
Bug #1853579 reported by
Caleb Ellis
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Low
|
Blake Rouse | ||
Bug Description
In the new UI we've rebuilt the add/edit user forms. The user model has a `first_name` param, however it doesn't update in the database when a new value is passed through the websocket. In the old angular forms the "Full name" field was simply showing and editing the `last_name` parameter, which updates correctly.
Do we implement it the same way for the React version? i.e. just ignore the `first_name` param? Or is this an actual bug in the websocket handler?
Related branches
~blake-rouse/maas:fix-1853579
- Alberto Donato (community): Approve
-
Diff: 24 lines (+0/-2)2 files modifiedsrc/maasserver/websockets/handlers/tests/test_user.py (+0/-1)
src/maasserver/websockets/handlers/user.py (+0/-1)
Revision history for this message
| Blake Rouse (blake-rouse) wrote | #1 |
| summary: |
- [websocket-api] user first_name does not save + [websocket-api] User first_name is unused and should be returned |
| Changed in maas: | |
| status: | New → In Progress |
| importance: | Undecided → Low |
| assignee: | nobody → Blake Rouse (blake-rouse) |
| milestone: | none → 2.7.0alpha1 |
| summary: |
- [websocket-api] User first_name is unused and should be returned + [websocket-api] User first_name is unused and should not be returned |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Correct only the last_name should be used for viewing and for editing. `first_name` should not actually be shown on the Websocket.