[websocket-api] NUMA node data for logical volumes
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
High
|
Alberto Donato |
Bug Description
In the latest designs for surfacing NUMA node information in the UI, the Machine details > Storage tab shows the following: https:/
Physical volumes are simple enough and the current API returns the NUMA node data correctly. However, volume groups, cache sets etc. do not return any NUMA node info and there is no way (as far as I can tell) to link a "parent" storage element to its "children". Therefore we cannot currently build a list of NUMA nodes associated with logical volumes.
I think this could be solved in a couple of ways:
1. Calculate NUMA node info for logical volumes in the backend and send it through the websocket directly, or;
2. Send the indices of the parents/children of volumes over the websocket (which is what currently happens with interfaces) and the list of NUMA nodes could then be calculated on the frontend.
Related branches
- Newell Jensen (community): Approve
- MAAS Lander: Approve
-
Diff: 449 lines (+277/-6)9 files modifiedsrc/maasserver/models/cacheset.py (+23/-0)
src/maasserver/models/filesystem.py (+16/-0)
src/maasserver/models/filesystemgroup.py (+17/-0)
src/maasserver/models/tests/test_cacheset.py (+34/-0)
src/maasserver/models/tests/test_filesystem.py (+41/-1)
src/maasserver/models/tests/test_filesystemgroup.py (+85/-0)
src/maasserver/models/virtualblockdevice.py (+4/-5)
src/maasserver/websockets/handlers/node.py (+2/-0)
src/maasserver/websockets/handlers/tests/test_machine.py (+55/-0)
Changed in maas: | |
status: | New → Triaged |
importance: | Undecided → High |
tags: | added: blocking-ui |
Changed in maas: | |
status: | Triaged → In Progress |
assignee: | nobody → Alberto Donato (ack) |
Changed in maas: | |
status: | In Progress → Fix Committed |
tags: | removed: blocking-ui |
Changed in maas: | |
status: | Fix Committed → Fix Released |