ScriptResult event emitter doesn't handle place holder
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
High
|
Lee Trager | ||
2.6 |
Fix Released
|
High
|
Lee Trager |
Bug Description
When storage or networking testing is run on a new machine the place holder 'all' is set as the parameter's value. maas-run-
Additionally for MAAS 2.7 the event emitter needs to handle interfaces.
2019-08-09 09:27:13 regiond: [info] 20.1.0.2 POST /MAAS/metadata/
2019-08-09 09:27:14 maasserver: [error] #######
2019-08-09 09:27:14 maasserver: [error] Traceback (most recent call last):
File "/usr/lib/
response = wrapped_
File "/usr/lib/
return view_atomic(*args, **kwargs)
File "/usr/lib/
return func(*args, **kwds)
File "/usr/lib/
response = upcall(request, *args, **kwargs)
File "/usr/lib/
response = func(*args, **kwargs)
File "/usr/lib/
result = self.error_
File "/usr/lib/
result = meth(request, *args, **kwargs)
File "/usr/lib/
return function(self, request, *args, **kwargs)
File "/usr/lib/
target_status = process(node, request, status)
File "/usr/lib/
node, node.current_
File "/usr/lib/
script_
File "/usr/lib/
return super().save(*args, **kwargs)
File "/usr/lib/
return super(CleanSave, self).save(*args, **kwargs)
File "/usr/lib/
return super(Timestamp
File "/usr/lib/
force_
File "/usr/lib/
update_
File "/usr/lib/
for receiver in self._live_
File "/usr/lib/
for receiver in self._live_
File "/usr/lib/
callback(
File "/usr/lib/
'storage', {}).get('value', {}).get('name')
AttributeError: 'str' object has no attribute 'get'
Related branches
- Lee Trager (community): Approve
- MAAS Lander: Pending (unittests) requested
-
Diff: 299 lines (+65/-45)7 files modifiedsrc/maasserver/api/tests/test_machines.py (+4/-0)
src/maasserver/api/tests/test_tag.py (+13/-2)
src/maasserver/models/signals/scriptresult.py (+17/-15)
src/maasserver/models/signals/tests/test_scriptresult.py (+16/-23)
src/maasserver/models/tests/test_blockdevice.py (+3/-2)
src/maasserver/testing/factory.py (+10/-1)
src/maasserver/websockets/handlers/tests/test_machine.py (+2/-2)
- MAAS Maintainers: Pending requested
-
Diff: 3421 lines (+1314/-676) (has conflicts)36 files modified.eslintrc.js (+3/-0)
Makefile (+7/-0)
debian/changelog (+11/-1)
debian/copyright (+0/-4)
dev/null (+0/-631)
jest.config.js (+6/-0)
package.json (+16/-0)
src/maasserver/models/signals/scriptresult.py (+6/-0)
src/maasserver/models/signals/tests/test_scriptresult.py (+13/-0)
src/maasserver/static/js/angular/controllers/pods_list.js (+5/-0)
src/maasserver/static/js/angular/controllers/settings.js (+114/-0)
src/maasserver/static/js/angular/controllers/tests/test_pods_list.js (+5/-0)
src/maasserver/static/js/angular/controllers/tests/test_settings.js (+264/-0)
src/maasserver/static/js/angular/controllers/tests/test_zones_list.js (+4/-0)
src/maasserver/static/js/angular/directives/machines_table.js (+31/-9)
src/maasserver/static/js/angular/directives/script_status.js (+3/-0)
src/maasserver/static/js/angular/directives/tests/test_machines_table.js (+30/-0)
src/maasserver/static/js/angular/entry.js (+1/-7)
src/maasserver/static/js/bundle/maas-min.js (+4/-0)
src/maasserver/static/js/bundle/maas-min.js.map (+5/-1)
src/maasserver/static/js/bundle/vendor-min.js (+4/-0)
src/maasserver/static/js/bundle/vendor-min.js.map (+5/-1)
src/maasserver/static/partials/dashboard.html (+1/-1)
src/maasserver/static/partials/machines-table.html (+24/-2)
src/maasserver/static/partials/networks-list.html (+2/-2)
src/maasserver/static/partials/node-events.html (+1/-1)
src/maasserver/static/partials/nodes-list.html (+66/-2)
src/maasserver/static/partials/pods-list.html (+5/-0)
src/maasserver/static/partials/subnet-details.html (+1/-1)
src/maasserver/static/partials/switches-table.html (+1/-1)
src/maasserver/static/partials/zones-list.html (+6/-0)
src/maasserver/testing/html-loader.js (+0/-0)
src/metadataserver/user_data/templates/snippets/maas_run_remote_scripts.py (+8/-0)
src/metadataserver/user_data/templates/snippets/tests/test_maas_run_remote_scripts.py (+20/-0)
src/provisioningserver/utils/version.py (+4/-0)
yarn.lock (+638/-12)
- Newell Jensen (community): Approve
- MAAS Lander: Needs Fixing
-
Diff: 349 lines (+118/-39)7 files modifiedsrc/maasserver/api/tests/test_machines.py (+4/-0)
src/maasserver/api/tests/test_tag.py (+13/-2)
src/maasserver/models/signals/scriptresult.py (+19/-10)
src/maasserver/models/signals/tests/test_scriptresult.py (+67/-22)
src/maasserver/models/tests/test_blockdevice.py (+3/-2)
src/maasserver/testing/factory.py (+10/-1)
src/maasserver/websockets/handlers/tests/test_machine.py (+2/-2)
Changed in maas: | |
importance: | Undecided → High |
milestone: | none → 2.7.0alpha1 |
Changed in maas: | |
status: | New → In Progress |
assignee: | nobody → Lee Trager (ltrager) |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
status: | Fix Committed → Fix Released |