| 2019-04-04 03:50:01 |
Lee Trager |
description |
When a TFTP client gives no options when requesting a file from MAAS the client is unable to to send an ACK for the first block. This results in the client and MAAS ping ponging between the client requesting the file, getting the first block, and failing to send the ACK and MAAS resending the first block. Clients which send TFTP options(e.g tsize, blksize) do not run into this problem as the negotiation of options gives MAAS enough time to open the UDP port to receive the ACK.
97da24b, which starts tracking TFTP file transfer time surfaced this bug. The following patch fixes MAAS however the underlying issue is the UDP port is not opening quick enough. A heavily loaded system without TFTP file transfer track would most likely run into the same issue.
diff --git a/src/provisioningserver/rackdservices/tftp.py b/src/provisioningserver/rackdservices/tftp.py
index a7f735c27..38b8b01b2 100644
--- a/src/provisioningserver/rackdservices/tftp.py
+++ b/src/provisioningserver/rackdservices/tftp.py
@@ -527,8 +527,7 @@ class TFTPService(MultiService, object):
for address in addrs_desired - addrs_established:
if not IPAddress(address).is_link_local():
tftp_service = UDPServer(
- self.port, TransferTimeTrackingTFTP(self.backend),
- interface=address)
+ self.port, TFTP(self.backend), interface=address)
tftp_service.setName(address)
tftp_service.setServiceParent(self)
Reproduction:
curl --tftp-no-options --max-time 5 tftp://$RACK_IP/pxelinux.cfg/default |
When a TFTP client gives no options when requesting a file from MAAS the client is unable to to send an ACK for the first block. This results in the client and MAAS ping ponging between the client requesting the file, getting the first block, and failing to send the ACK and MAAS resending the first block. Clients which send TFTP options(e.g tsize, blksize) do not run into this problem as the negotiation of options gives MAAS enough time to open the UDP port to receive the ACK.
97da24b, which starts tracking TFTP file transfer time surfaced this bug. The following patch fixes MAAS however the underlying issue is the UDP port is not opening quick enough. A heavily loaded system without TFTP file transfer tracking would most likely run into the same issue.
diff --git a/src/provisioningserver/rackdservices/tftp.py b/src/provisioningserver/rackdservices/tftp.py
index a7f735c27..38b8b01b2 100644
--- a/src/provisioningserver/rackdservices/tftp.py
+++ b/src/provisioningserver/rackdservices/tftp.py
@@ -527,8 +527,7 @@ class TFTPService(MultiService, object):
for address in addrs_desired - addrs_established:
if not IPAddress(address).is_link_local():
tftp_service = UDPServer(
- self.port, TransferTimeTrackingTFTP(self.backend),
- interface=address)
+ self.port, TFTP(self.backend), interface=address)
tftp_service.setName(address)
tftp_service.setServiceParent(self)
Reproduction:
curl --tftp-no-options --max-time 5 tftp://$RACK_IP/pxelinux.cfg/default |
|
