[2.5, RBAC, UI, API] Operator/admin can't edit storage for machines

[Björn Tillenius]

This is testing with MAAS 2.5.1-7489-g2f25a2cc0-0ubuntu1~18.04.1.

Logged in as a user that has either the Operator or Admin role in RBAC
for the resource pool the machine belongs to, I can't edit
the storage of machines in the pool.

I should be able to admin the machine, and I can indeed modify the
network settings.

This applies to both the UI and the API. Although in the API, you
can create and delete partitions, but you can't format or mount them.

[Alberto Donato (ack)]

FWIW I can edit storage for a machine as admin with RBAC, not as operator.
I think the latter is expected.

[Alberto Donato (ack)]

Ok, it turns out you can only edit storage if you have admin on the global scope (so user.is_superuser is True).

The logic for the storage tab looks at the flag rather than permissions for displaying storage actions

[Björn Tillenius (bjornt)]

Turns out that the API is broken as well.

  > maas user4 partition mount wxakrn 33 28 mount_point=/
  Cannot mount partition because you don't have the permissions on a Ready node.

[Jerzy Husakowski (jhusakowski)]

Is this issue still reproducible in a recent MAAS?