[21.5b2] ERROR 'NoneType' object has no attribute 'relay_vlan'

[Chris Gregan]

2.5 MAAS deployment fails due to relay_vlan not found.

2018-10-10-10:52:35 INFO Creating grafana-1 in leafeon
2018-10-10-10:52:35 DEBUG maas root pod compose 1 hostname=grafana-1 cores=2 memory=2048 storage=40 zone=1
2018-10-10-10:52:38 ERROR Command failed: pod compose 1 hostname=grafana-1 cores=2 memory=2048 storage=40 zone=1
2018-10-10-10:52:38 ERROR 'NoneType' object has no attribute 'relay_vlan'
Traceback (most recent call last):
  File "/usr/local/bin/fce", line 11, in <module>
    load_entry_point('foundationcloudengine', 'console_scripts', 'fce')()
  File "/home/ubuntu/cpe/foundation/foundationcloudengine/foundationcloudengine/main.py", line 102, in entry_point
    sys.exit(main(sys.argv[1:]))
  File "/home/ubuntu/cpe/foundation/foundationcloudengine/foundationcloudengine/main.py", line 93, in main
    opts.func(opts)
  File "/home/ubuntu/cpe/foundation/foundationcloudengine/foundationcloudengine/build.py", line 38, in build_main
    layer.build()
  File "/home/ubuntu/cpe/foundation/foundationcloudengine/foundationcloudengine/layers/maaslayer.py", line 307, in build
    self.setup_pods()
  File "/home/ubuntu/cpe/foundation/foundationcloudengine/foundationcloudengine/layers/maaslayer.py", line 790, in setup_pods
    zone['id'],
  File "/home/ubuntu/cpe/foundation/foundationcloudengine/foundationcloudengine/maas_cli.py", line 402, in add_pod_vm
    return cmd(maas_profile, command)
  File "/home/ubuntu/cpe/foundation/foundationcloudengine/foundationcloudengine/maas_cli.py", line 100, in cmd
    raise error
subprocess.CalledProcessError: Command '['maas', 'root', 'pod', 'compose', '1', 'hostname=grafana-1', 'cores=2', 'memory=2048', 'storage=40', 'zone=1']' returned non-zero exit status 2
Exception in thread Thread-3 (most likely raised during interpreter shutdown):
Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 801, in __bootstrap_inner
  File "/usr/lib/python2.7/dist-packages/paramiko/transport.py", line 1832, in run
<type 'exceptions.AttributeError'>: 'NoneType' object has no attribute 'error'
Build step 'Execute shell' marked build as failure

[Chris Gregan (cgregan)]

Link to deployment artifacts: https://oil-jenkins.canonical.com/artifacts/b316f1b5-6b86-4fe1-b4a5-5e89beb0e389/index.html

[Andres Rodriguez (andreserl)]

The actual traceback in MAAS is:

(gzip))
2018-10-10 10:52:37 maasserver: [error] ################################ Exception: 'NoneType' object has no attribute 'relay_vlan' ################################
2018-10-10 10:52:37 maasserver: [error] Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/django/core/handlers/base.py", line 185, in _get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "/usr/lib/python3/dist-packages/maasserver/utils/views.py", line 277, in view_atomic_with_post_commit_savepoint
    return view_atomic(*args, **kwargs)
  File "/usr/lib/python3.6/contextlib.py", line 52, in inner
    return func(*args, **kwds)
  File "/usr/lib/python3/dist-packages/maasserver/api/support.py", line 70, in __call__
    response = upcall(request, *args, **kwargs)
  File "/usr/lib/python3/dist-packages/django/views/decorators/vary.py", line 21, in inner_func
    response = func(*args, **kwargs)
  File "/usr/lib/python3/dist-packages/piston3/resource.py", line 190, in __call__
    result = self.error_handler(e, request, meth, em_format)
  File "/usr/lib/python3/dist-packages/piston3/resource.py", line 188, in __call__
    result = meth(request, *args, **kwargs)
  File "/usr/lib/python3/dist-packages/maasserver/api/support.py", line 310, in dispatch
    return function(self, request, *args, **kwargs)
  File "/usr/lib/python3/dist-packages/maasserver/api/support.py", line 173, in wrapper
    return func(self, request, *args, **kwargs)
  File "/usr/lib/python3/dist-packages/maasserver/api/pods.py", line 283, in compose
    machine = form.compose()
  File "/usr/lib/python3/dist-packages/maasserver/forms/pods.py", line 623, in compose
    _, result = db_work(None)
  File "/usr/lib/python3/dist-packages/maasserver/forms/pods.py", line 560, in db_work
    for interface in self.pod.host.interface_set.all()
  File "/usr/lib/python3/dist-packages/maasserver/forms/pods.py", line 560, in <listcomp>
    for interface in self.pod.host.interface_set.all()
AttributeError: 'NoneType' object has no attribute 'relay_vlan'

[Andres Rodriguez (andreserl)]

This log is in .31.

[Andres Rodriguez (andreserl)]

To confirm, a physical bridge is created and a 'maas' network is created on libvirt side to provide networking to the VMs.

[Mike Pontillo (mpontillo)]

@cgregan, I've linked a merge proposal that should fix this. If you'd like to apply the patch and test MAAS with this change, that would be much appreciated.

[Mike Pontillo (mpontillo)]

For the record, this issue only seems to surface when we have pod hosts that have interfaces where the VLAN is disconnected.