[2.5, UI] BMC enlistment - Adding a machine via the UI doesn't validate IP address
Bug #1789290 reported by
Andres Rodriguez
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
High
|
Newell Jensen | ||
Bug Description
By Mistake, I put a URL in the IP address field when adding a machine with IPMI, and the machine was added correctly and no IP validation performed.
Note that power parameters should be validating a correct IP or Host depending on which power param it is.
Related branches
~newell-jensen/maas:lp1789290
- Andres Rodriguez (community): Needs Information
- MAAS Lander: Approve
- Lee Trager (community): Approve
-
Diff: 88 lines (+14/-16)4 files modifiedsrc/maasserver/api/tests/test_machine.py (+1/-1)
src/maasserver/models/bmc.py (+2/-1)
src/maasserver/models/tests/test_bmc.py (+11/-0)
src/maasserver/models/tests/test_node.py (+0/-14)
Revision history for this message
| Andres Rodriguez (andreserl) wrote | #1 |
| description: | updated |
| Changed in maas: | |
| milestone: | none → 2.5.0beta1 |
| importance: | Undecided → High |
| status: | New → Triaged |
| summary: |
- [2.5] BMC enlistment - Adding a machine via the UI doesn't validate IP - address + [2.5, UI] BMC enlistment - Adding a machine via the UI doesn't validate + IP address |
| tags: | added: bmc-enlistment track |
| Changed in maas: | |
| assignee: | nobody → Newell Jensen (newell-jensen) |
| Changed in maas: | |
| milestone: | 2.5.0beta1 → 2.5.0beta2 |
| tags: | added: sprint |
| Changed in maas: | |
| status: | Triaged → In Progress |
| Changed in maas: | |
| milestone: | 2.5.0beta2 → 2.5.0rc1 |
Revision history for this message
| Newell Jensen (newell-jensen) wrote | #2 |
| Changed in maas: | |
| status: | In Progress → Triaged |
| Changed in maas: | |
| status: | Triaged → In Progress |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
The error was not being raised, when raised it results in this stacktrace:
https:/