MAAS

[2.5] Validation of SRV records raises incorrect exception for malformed records

Bug #1782409 reported by Kit Randel on 2018-07-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
​ MAAS
Fix Released
High
Mike Pontillo
MAAS 2.5.0beta1
Also affects project (?) Also affects distribution/package Nominate for series

Bug Description

Attempting to add a SRV DNS record results in the exception:

'NoneType' object has no attribute 'groupdict'

Related branches

~mpontillo/maas:fix-srv-record-validation--bug-1782409
Alberto Donato: Approve on 2018-09-06
MAAS Lander: Approve on 2018-09-05
Diff: 30 lines (+5/-1)
2 files modified
src/maasserver/models/dnsdata.py (+1/-1)
src/maasserver/models/tests/test_dnsdata.py (+4/-0)
Kit Randel (blr) wrote :

Screenshot

Andres Rodriguez (andreserl) wrote :

Hi Kit,

Could you please:

1. Specify the version where this issue exists?
2. Attach /var/log/maas/regiond.log ?

Thanks.

Changed in maas:
status: New → Incomplete
Kit Randel (blr) on 2018-07-18
summary: - Adding a SRV DNS record crashes
+ [2.5.x] Adding a SRV DNS record crashes
Kit Randel (blr) wrote : Re: [2.5.x] Adding a SRV DNS record crashes

Hi Andres,

This is against master, so I've indicated v2.5.x in the title, and attached the regiond log.

Andres Rodriguez (andreserl) on 2018-07-18
Changed in maas:
milestone: none → 2.5.0
importance: Undecided → Critical
status: Incomplete → Triaged
summary: - [2.5.x] Adding a SRV DNS record crashes
+ [2.5] Adding a SRV DNS record crashes
Changed in maas:
assignee: nobody → Blake Rouse (blake-rouse)
Andres Rodriguez (andreserl) on 2018-08-01
Changed in maas:
milestone: 2.5.0 → 2.5.0alpha2
tags: added: track
Andres Rodriguez (andreserl) on 2018-08-23
Changed in maas:
milestone: 2.5.0alpha2 → 2.5.0beta1
Andres Rodriguez (andreserl) on 2018-09-04
Changed in maas:
assignee: Blake Rouse (blake-rouse) → Mike Pontillo (mpontillo)
Mike Pontillo (mpontillo) wrote : Re: [2.5] Adding a SRV DNS record crashes

This is actually just a bug in the error message.

If you specify a SRV record with correct syntax, it works correctly. For example, I was able to add a SRV record with the following data to my test MAAS:

    0 5 5060 sipserver.maas

Changed in maas:
importance: Critical → High
Mike Pontillo (mpontillo) on 2018-09-05
summary: - [2.5] Adding a SRV DNS record crashes
+ [2.5] Validation of SRV records raises for malformed records
Mike Pontillo (mpontillo) on 2018-09-05
summary: - [2.5] Validation of SRV records raises for malformed records
+ [2.5] Validation of SRV records raises incorrect exception for malformed
+ records
MAAS Lander (maas-lander) on 2018-09-06
Changed in maas:
status: Triaged → Fix Committed
Andres Rodriguez (andreserl) on 2018-09-18
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.
Subscribing...

Other bug subscribers