builtins.ValueError: too many values to unpack (expected 3)

Bug #1772679 reported by Andres Rodriguez on 2018-05-22
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Medium
Blake Rouse
2.4
Medium
Blake Rouse

Bug Description

The CI had a non-standard versioning scheme like the following:

2.4.0+6981.g011e51b+ci-0ubuntu1

On 2.3, with the same format, it would register correctly. This issue is due to commit:

 7df0631dae844d7fc67913882f1036e2c97c8744 / LP: #1770126 .

The error shown is

            return func(*args, **kwargs)
          File "/usr/lib/python3/dist-packages/maasserver/utils/orm.py", line 756, in call_within_transaction
            return func_outside_txn(*args, **kwargs)
          File "/usr/lib/python3/dist-packages/maasserver/utils/orm.py", line 563, in retrier
            return func(*args, **kwargs)
          File "/usr/lib/python3.6/contextlib.py", line 52, in inner
            return func(*args, **kwds)
          File "/usr/lib/python3/dist-packages/maasserver/rpc/rackcontrollers.py", line 157, in register
            ControllerInfo.objects.set_version(rackcontroller, version)
          File "/usr/lib/python3/dist-packages/maasserver/models/controllerinfo.py", line 83, in set_version
            self.update_or_create(defaults=dict(version=version), node=controller)
          File "/usr/lib/python3/dist-packages/django/db/models/manager.py", line 85, in manager_method
            return getattr(self.get_queryset(), name)(*args, **kwargs)
          File "/usr/lib/python3/dist-packages/django/db/models/query.py", line 482, in update_or_create
            obj, created = self._create_object_from_params(lookup, params)
          File "/usr/lib/python3/dist-packages/django/db/models/query.py", line 498, in _create_object_from_params
            obj = self.create(**params)
          File "/usr/lib/python3/dist-packages/django/db/models/query.py", line 394, in create
            obj.save(force_insert=True, using=self.db)
          File "/usr/lib/python3/dist-packages/maasserver/models/cleansave.py", line 214, in save
            return super(CleanSave, self).save(*args, **kwargs)
          File "/usr/lib/python3/dist-packages/maasserver/models/timestampedmodel.py", line 90, in save
            return super(TimestampedModel, self).save(*args, **kwargs)
          File "/usr/lib/python3/dist-packages/django/db/models/base.py", line 808, in save
            force_update=force_update, update_fields=update_fields)
          File "/usr/lib/python3/dist-packages/django/db/models/base.py", line 848, in save_base
            update_fields=update_fields, raw=raw, using=using,
          File "/usr/lib/python3/dist-packages/django/dispatch/dispatcher.py", line 193, in send
            for receiver in self._live_receivers(sender)
          File "/usr/lib/python3/dist-packages/django/dispatch/dispatcher.py", line 193, in <listcomp>
            for receiver in self._live_receivers(sender)
          File "/usr/lib/python3/dist-packages/maasserver/models/signals/controllerinfo.py", line 30, in post_save__update_version_notifications
            update_version_notifications()
          File "/usr/lib/python3/dist-packages/maasserver/models/controllerinfo.py", line 141, in update_version_notifications
            ControllerInfo.objects.get_controller_version_info()
          File "/usr/lib/python3/dist-packages/maasserver/models/controllerinfo.py", line 100, in get_controller_version_info
            version_info.append(get_version_tuple(version_info[-1]))
          File "/usr/lib/python3/dist-packages/provisioningserver/utils/version.py", line 148, in get_version_tuple
            major, minor, point = major_minor_point
        builtins.ValueError: too many values to unpack (expected 3)

This is

Related branches

Changed in maas:
milestone: none → 2.5.0
Changed in maas:
status: New → Fix Committed
importance: Undecided → Medium
assignee: nobody → Blake Rouse (blake-rouse)
Changed in maas:
milestone: 2.5.0 → 2.5.0alpha1
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers