[2.4b3] When SMART is not supported on a drive, some tests pass and some are skipped

Bug #1770141 reported by Mark Shuttleworth on 2018-05-09
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Medium
Unassigned

Bug Description

I have a machine with a disk which apparently does not support SMART, because this is the output for the tests smartctl-long, smartctl-short and smartctl-validate:

  INFO: Veriying SMART support for the following drive: /dev/sdb

  INFO: Running command: sudo -n smartctl --all /dev/sdb

  INFO: Unable to run test. The following drive does not support SMART: /dev/sdb

However, two of those tests say they 'passed' and one says it was 'skipped'. We should be consistent in signalling when a test is not appropriate; this should be an AMBER result with a message like 'Test skipped because XYZ'.

Andres Rodriguez (andreserl) wrote :

Hi Mark,

I think the inconsistency here is that we recently fixed an issue where MAAS would incorrectly mark the test as "passed" instead of "skipped". Since we recently fixed it, only test runs performed after the fix will correctly reflect the result, and all previous will continue to show as 'passed', since we don't really know they were actually skipped before this fix.

That said, for the AMBER result, do you mean in the overall health for the hardware tests (on the Hardware Tests tab), or for the disk itself (on the storage details section?).

Changed in maas:
status: New → Incomplete
importance: Undecided → Medium
milestone: none → 2.4.x

Ah, the timing might explain the results discrepancy I will check.

Generally, it's nice to have a traffic-light-plus-message pattern.
Traffic lights are easy to scan and to parse (red/amber/green). Messages
tell humans how to feel about that.

So for scripts/tests, it makes sense that their output is:

 * a traffic light
 * a message
 * optionally, logs

Mark

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers