MAAS

[2.x] Curtin config doesn't output tmpfs and ramfs YAML storage layout

Bug #1767979 reported by Blake Rouse
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
High
Alberto Donato
MAAS 2.4.0rc1
curtin
Fix Released
Medium
Scott Moser

Bug Description

I added 2 special filesystems to my machine both tmpfs and ramfs.

Machine output with filesystems: http://paste.ubuntu.com/p/nBSgNPwDzj/
Curtin preseed: http://paste.ubuntu.com/p/5yfNYHbzDZ/

The curtin preseed should contain the required YAML so the /etc/fstab is written correctly. At the moment curtin doesn't actually has a defined YAML for this.

Related branches

~raharper/curtin:ubuntu/xenial/sru-20180518
Server Team CI bot: Approve (continuous-integration)
curtin developers: Pending requested
Diff: 3718 lines (+1736/-596)
48 files modified
curtin/block/__init__.py (+18/-14)
curtin/block/bcache.py (+87/-0)
curtin/block/clear_holders.py (+90/-52)
curtin/block/iscsi.py (+7/-8)
curtin/block/mdadm.py (+68/-4)
curtin/block/zfs.py (+26/-1)
curtin/commands/apt_config.py (+5/-0)
curtin/commands/block_meta.py (+173/-76)
curtin/commands/curthooks.py (+3/-3)
curtin/commands/install.py (+22/-23)
curtin/util.py (+35/-25)
debian/changelog (+22/-0)
dev/null (+0/-128)
doc/topics/integration-testing.rst (+16/-0)
doc/topics/storage.rst (+61/-4)
examples/tests/dirty_disks_config.yaml (+6/-0)
examples/tests/filesystem_battery.yaml (+23/-0)
examples/tests/lvm.yaml (+21/-0)
tests/unittests/helpers.py (+3/-1)
tests/unittests/test_block_zfs.py (+96/-0)
tests/unittests/test_clear_holders.py (+87/-38)
tests/unittests/test_commands_block_meta.py (+425/-25)
tests/unittests/test_commands_install.py (+28/-0)
tests/unittests/test_make_dname.py (+28/-1)
tests/unittests/test_util.py (+47/-0)
tests/vmtests/__init__.py (+146/-19)
tests/vmtests/helpers.py (+49/-32)
tests/vmtests/test_basic.py (+12/-9)
tests/vmtests/test_centos_basic.py (+0/-2)
tests/vmtests/test_fs_battery.py (+49/-0)
tests/vmtests/test_lvm.py (+6/-10)
tests/vmtests/test_lvm_iscsi.py (+8/-2)
tests/vmtests/test_mdadm_bcache.py (+7/-73)
tests/vmtests/test_network.py (+0/-1)
tests/vmtests/test_network_alias.py (+0/-1)
tests/vmtests/test_network_bonding.py (+0/-1)
tests/vmtests/test_network_bridging.py (+0/-1)
tests/vmtests/test_network_ipv6.py (+0/-1)
tests/vmtests/test_network_mtu.py (+0/-1)
tests/vmtests/test_network_static.py (+0/-1)
tests/vmtests/test_network_vlan.py (+6/-1)
tests/vmtests/test_nvme.py (+0/-18)
tests/vmtests/test_pollinate_useragent.py (+2/-2)
tests/vmtests/test_raid5_bcache.py (+0/-4)
tests/vmtests/test_uefi_basic.py (+0/-9)
tests/vmtests/test_zfsroot.py (+40/-1)
tools/jenkins-runner (+12/-0)
tools/vmtest-sync-images (+2/-4)
~raharper/curtin:ubuntu/artful/sru-20180518
Server Team CI bot: Approve (continuous-integration)
curtin developers: Pending requested
Diff: 3718 lines (+1736/-596)
48 files modified
curtin/block/__init__.py (+18/-14)
curtin/block/bcache.py (+87/-0)
curtin/block/clear_holders.py (+90/-52)
curtin/block/iscsi.py (+7/-8)
curtin/block/mdadm.py (+68/-4)
curtin/block/zfs.py (+26/-1)
curtin/commands/apt_config.py (+5/-0)
curtin/commands/block_meta.py (+173/-76)
curtin/commands/curthooks.py (+3/-3)
curtin/commands/install.py (+22/-23)
curtin/util.py (+35/-25)
debian/changelog (+22/-0)
dev/null (+0/-128)
doc/topics/integration-testing.rst (+16/-0)
doc/topics/storage.rst (+61/-4)
examples/tests/dirty_disks_config.yaml (+6/-0)
examples/tests/filesystem_battery.yaml (+23/-0)
examples/tests/lvm.yaml (+21/-0)
tests/unittests/helpers.py (+3/-1)
tests/unittests/test_block_zfs.py (+96/-0)
tests/unittests/test_clear_holders.py (+87/-38)
tests/unittests/test_commands_block_meta.py (+425/-25)
tests/unittests/test_commands_install.py (+28/-0)
tests/unittests/test_make_dname.py (+28/-1)
tests/unittests/test_util.py (+47/-0)
tests/vmtests/__init__.py (+146/-19)
tests/vmtests/helpers.py (+49/-32)
tests/vmtests/test_basic.py (+12/-9)
tests/vmtests/test_centos_basic.py (+0/-2)
tests/vmtests/test_fs_battery.py (+49/-0)
tests/vmtests/test_lvm.py (+6/-10)
tests/vmtests/test_lvm_iscsi.py (+8/-2)
tests/vmtests/test_mdadm_bcache.py (+7/-73)
tests/vmtests/test_network.py (+0/-1)
tests/vmtests/test_network_alias.py (+0/-1)
tests/vmtests/test_network_bonding.py (+0/-1)
tests/vmtests/test_network_bridging.py (+0/-1)
tests/vmtests/test_network_ipv6.py (+0/-1)
tests/vmtests/test_network_mtu.py (+0/-1)
tests/vmtests/test_network_static.py (+0/-1)
tests/vmtests/test_network_vlan.py (+6/-1)
tests/vmtests/test_nvme.py (+0/-18)
tests/vmtests/test_pollinate_useragent.py (+2/-2)
tests/vmtests/test_raid5_bcache.py (+0/-4)
tests/vmtests/test_uefi_basic.py (+0/-9)
tests/vmtests/test_zfsroot.py (+40/-1)
tools/jenkins-runner (+12/-0)
tools/vmtest-sync-images (+2/-4)
~raharper/curtin:ubuntu/bionic/sru-20180518
Server Team CI bot: Approve (continuous-integration)
curtin developers: Pending requested
Diff: 3486 lines (+1640/-558)
44 files modified
curtin/block/__init__.py (+18/-14)
curtin/block/bcache.py (+87/-0)
curtin/block/clear_holders.py (+88/-51)
curtin/block/iscsi.py (+7/-8)
curtin/block/mdadm.py (+65/-0)
curtin/block/zfs.py (+26/-1)
curtin/commands/apt_config.py (+5/-0)
curtin/commands/block_meta.py (+173/-76)
curtin/commands/curthooks.py (+2/-2)
curtin/util.py (+35/-25)
debian/changelog (+18/-0)
dev/null (+0/-128)
doc/topics/integration-testing.rst (+16/-0)
doc/topics/storage.rst (+61/-4)
examples/tests/dirty_disks_config.yaml (+6/-0)
examples/tests/filesystem_battery.yaml (+23/-0)
tests/unittests/helpers.py (+3/-1)
tests/unittests/test_block_zfs.py (+96/-0)
tests/unittests/test_clear_holders.py (+82/-33)
tests/unittests/test_commands_block_meta.py (+425/-25)
tests/unittests/test_make_dname.py (+28/-1)
tests/unittests/test_util.py (+47/-0)
tests/vmtests/__init__.py (+145/-18)
tests/vmtests/helpers.py (+49/-32)
tests/vmtests/test_basic.py (+12/-9)
tests/vmtests/test_centos_basic.py (+0/-2)
tests/vmtests/test_fs_battery.py (+49/-0)
tests/vmtests/test_lvm.py (+5/-9)
tests/vmtests/test_lvm_iscsi.py (+8/-2)
tests/vmtests/test_mdadm_bcache.py (+7/-73)
tests/vmtests/test_network.py (+0/-1)
tests/vmtests/test_network_alias.py (+0/-1)
tests/vmtests/test_network_bonding.py (+0/-1)
tests/vmtests/test_network_bridging.py (+0/-1)
tests/vmtests/test_network_ipv6.py (+0/-1)
tests/vmtests/test_network_mtu.py (+0/-1)
tests/vmtests/test_network_static.py (+0/-1)
tests/vmtests/test_network_vlan.py (+0/-1)
tests/vmtests/test_nvme.py (+0/-18)
tests/vmtests/test_raid5_bcache.py (+0/-4)
tests/vmtests/test_uefi_basic.py (+0/-9)
tests/vmtests/test_zfsroot.py (+40/-1)
tools/jenkins-runner (+12/-0)
tools/vmtest-sync-images (+2/-4)
~ack/maas:preseed-special-mounts
Andres Rodriguez (community): Approve
MAAS Lander: Approve
Blake Rouse (community): Approve
Diff: 81 lines (+47/-5)
2 files modified
src/maasserver/preseed_storage.py (+17/-5)
src/maasserver/tests/test_preseed_storage.py (+30/-0)
~smoser/curtin:bug/1767979-support-tmpfs-mounts
Ryan Harper (community): Approve
Server Team CI bot: Approve (continuous-integration)
Diff: 841 lines (+629/-76)
6 files modified
curtin/commands/block_meta.py (+145/-69)
doc/topics/storage.rst (+53/-3)
examples/tests/filesystem_battery.yaml (+23/-0)
tests/unittests/helpers.py (+3/-1)
tests/unittests/test_commands_block_meta.py (+356/-3)
tests/vmtests/test_fs_battery.py (+49/-0)
Blake Rouse (blake-rouse)
Changed in curtin:
status: New → Confirmed
Andres Rodriguez (andreserl)
Changed in maas:
assignee: nobody → Mike Pontillo (mpontillo)
Andres Rodriguez (andreserl)
Changed in maas:
assignee: Mike Pontillo (mpontillo) → Alberto Donato (ack)
Revision history for this message
Scott Moser (smoser) wrote :

started something at
 https://code.launchpad.net/~smoser/curtin/+git/curtin/+ref/bug/1767979-support-tmpfs-mounts

the intent there is to allow storage config to contain
 'spec' and 'fstype'

So MAAS could send something like:

storage:
 version: 1
 config:
   - id: mytmpfs
     type: mount
     spec: mytmpfs
     path: /tmpfs
     options: noexec,size=1024k

Revision history for this message
Blake Rouse (blake-rouse) wrote :

Do you mean:

spec: tmpfs ?

in the comment you have:

spec: mytmpfs

Revision history for this message
Ryan Harper (raharper) wrote : Re: [Bug 1767979] Re: [2.x] Curtin config doesn't output tmpfs and ramfs YAML storage layout

For non device based mounts, you can use whatever, it may make more
sense to put tmpfs, or proc, or ramfs, etc...

That ultimately renders out to this fstab entry:

mytmpfs tmpfs /tmpfs noexec,size=1024k

On Fri, May 4, 2018 at 12:14 AM, Blake Rouse <email address hidden> wrote:
> Do you mean:
>
> spec: tmpfs ?
>
>
> in the comment you have:
>
> spec: mytmpfs
>
> --
> You received this bug notification because you are subscribed to curtin.
> Matching subscriptions: curtin-bugs-all
> https://bugs.launchpad.net/bugs/1767979
>
> Title:
> [2.x] Curtin config doesn't output tmpfs and ramfs YAML storage layout
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/curtin/+bug/1767979/+subscriptions

Scott Moser (smoser)
Changed in curtin:
importance: Undecided → Medium
Andres Rodriguez (andreserl)
Changed in curtin:
status: Confirmed → In Progress
Alberto Donato (ack)
Changed in maas:
status: Triaged → In Progress
Scott Moser (smoser)
Changed in curtin:
assignee: nobody → Scott Moser (smoser)
MAAS Lander (maas-lander)
Changed in maas:
status: In Progress → Fix Committed
Revision history for this message
Ryan Harper (raharper) wrote :

An upstream commit landed for this bug.

To view that commit see the following URL:
https://git.launchpad.net/curtin/commit/?id=9e6e66af

Changed in curtin:
status: In Progress → Fix Committed
Andres Rodriguez (andreserl)
Changed in maas:
status: Fix Committed → Fix Released
Revision history for this message
Ryan Harper (raharper) wrote : Fixed in curtin version 18.1-17-gae48e86f-0ubuntu1.

This bug is believed to be fixed in curtin in version18.1-17-gae48e86f-0ubuntu1. If this is still a problem for you, please make a comment and set the state back to New

Thank you.

Changed in curtin:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.