[2.4, regression] Applying tag with a definition no longer works
Bug #1767257 reported by
Andres Rodriguez
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Critical
|
Blake Rouse |
Bug Description
The CI has a test that creates a tag with a definition that is applied to all machines. This tag mechanism has stopped working and CI is failing on it. To test manually, you can do:
maas <user> tags create name=all definition='true()' comment="tag that applies to all machines"
This should have added the tag to all machines, but it is not doing so.
Related branches
~blake-rouse/maas:fix-1742971-2.3
- Blake Rouse (community): Disapprove
- MAAS Lander: Needs Fixing
-
Diff: 2113 lines (+309/-297)70 files modifiedsrc/apiclient/maas_client.py (+8/-1)
src/apiclient/tests/test_maas_client.py (+7/-0)
src/maascli/actions/tests/test_boot_resources_create.py (+1/-1)
src/maascli/actions/tests/test_sshkeys_import.py (+1/-1)
src/maasserver/api/doc_handler.py (+1/-1)
src/maasserver/api/tests/test_api.py (+6/-6)
src/maasserver/api/tests/test_bcache.py (+2/-2)
src/maasserver/api/tests/test_bcache_cacheset.py (+2/-2)
src/maasserver/api/tests/test_boot_resources.py (+3/-3)
src/maasserver/api/tests/test_boot_source_selections.py (+2/-2)
src/maasserver/api/tests/test_boot_sources.py (+2/-2)
src/maasserver/api/tests/test_devices.py (+2/-2)
src/maasserver/api/tests/test_dhcpsnippets.py (+3/-3)
src/maasserver/api/tests/test_discoveries.py (+2/-2)
src/maasserver/api/tests/test_dnsresourcerecords.py (+2/-2)
src/maasserver/api/tests/test_dnsresources.py (+2/-2)
src/maasserver/api/tests/test_doc.py (+2/-2)
src/maasserver/api/tests/test_domains.py (+2/-2)
src/maasserver/api/tests/test_events.py (+1/-1)
src/maasserver/api/tests/test_fabrics.py (+2/-2)
src/maasserver/api/tests/test_fannetworks.py (+2/-2)
src/maasserver/api/tests/test_filestorage.py (+2/-2)
src/maasserver/api/tests/test_interfaces.py (+2/-2)
src/maasserver/api/tests/test_ipaddresses.py (+1/-1)
src/maasserver/api/tests/test_ipranges.py (+2/-2)
src/maasserver/api/tests/test_licensekey.py (+2/-2)
src/maasserver/api/tests/test_machine.py (+1/-1)
src/maasserver/api/tests/test_machines.py (+1/-1)
src/maasserver/api/tests/test_network.py (+2/-1)
src/maasserver/api/tests/test_networks.py (+2/-1)
src/maasserver/api/tests/test_node.py (+1/-1)
src/maasserver/api/tests/test_nodes.py (+1/-1)
src/maasserver/api/tests/test_notification.py (+2/-2)
src/maasserver/api/tests/test_packagerepositories.py (+4/-3)
src/maasserver/api/tests/test_pods.py (+2/-2)
src/maasserver/api/tests/test_rackcontroller.py (+3/-2)
src/maasserver/api/tests/test_raid.py (+2/-2)
src/maasserver/api/tests/test_regioncontroller.py (+2/-2)
src/maasserver/api/tests/test_scriptresults.py (+5/-5)
src/maasserver/api/tests/test_scripts.py (+4/-4)
src/maasserver/api/tests/test_spaces.py (+2/-2)
src/maasserver/api/tests/test_ssl_key.py (+2/-2)
src/maasserver/api/tests/test_staticroutes.py (+2/-2)
src/maasserver/api/tests/test_subnets.py (+2/-2)
src/maasserver/api/tests/test_tag.py (+2/-2)
src/maasserver/api/tests/test_users.py (+2/-2)
src/maasserver/api/tests/test_version.py (+1/-1)
src/maasserver/api/tests/test_vlans.py (+3/-2)
src/maasserver/api/tests/test_volume_groups.py (+2/-2)
src/maasserver/api/tests/test_zone.py (+2/-1)
src/maasserver/api/tests/test_zones.py (+1/-1)
src/maasserver/bootresources.py (+1/-7)
src/maasserver/djangosettings/monkey.py (+6/-6)
src/maasserver/djangosettings/settings.py (+9/-5)
src/maasserver/djangosettings/urls.py (+1/-1)
src/maasserver/middleware.py (+52/-60)
src/maasserver/testing/factory.py (+2/-2)
src/maasserver/testing/testclient.py (+26/-1)
src/maasserver/tests/test_bootresources.py (+8/-7)
src/maasserver/tests/test_commands.py (+1/-1)
src/maasserver/tests/test_middleware.py (+35/-17)
src/maasserver/tests/test_preseed.py (+5/-4)
src/maasserver/utils/__init__.py (+10/-27)
src/maasserver/utils/tests/test_utils.py (+10/-36)
src/maasserver/views/tests/test_account.py (+12/-12)
src/maasserver/views/tests/test_general.py (+3/-3)
src/maasserver/views/tests/test_settings.py (+3/-3)
src/metadataserver/middleware.py (+1/-1)
src/provisioningserver/tags.py (+2/-2)
src/provisioningserver/tests/test_tags.py (+5/-5)
~blake-rouse/maas:fix-1767257
Merged
into
maas:master
- Andres Rodriguez (community): Approve
-
Diff: 38 lines (+15/-1)2 files modifiedsrc/apiclient/maas_client.py (+8/-1)
src/apiclient/tests/test_maas_client.py (+7/-0)
Changed in maas: | |
importance: | Undecided → Critical |
milestone: | none → 2.4.0rc1 |
status: | New → Triaged |
Changed in maas: | |
status: | Triaged → In Progress |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
milestone: | 2.4.0rc1 → 2.4.0beta3 |
Changed in maas: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Rev. 7b6558214af4e0a 502670b21e9962f e4fbe93535 was the last branch where this test was ssuccessful. 15fa17b3d6e57e1 ed24cbab4b is the first rev where this test fails. That seems a regression introduced with the absolute_reverse fixes.
Rev. ce45829f85cd12f