[2.4, websockets] Domain handler sends update to all pages with controller loaded
Bug #1759525 reported by
Lee Trager
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Medium
|
Lee Trager | ||
Bug Description
The DomainHandler sends an update whenever a machine is added or removed from the domain. The DomainHandler is loaded on the node-details, node-listing, pods, and dash board to allow the user to select which domain the node should be on. Only the DNS page actually shows the count.
Ideally DomainHandler would never send an update for the count on these pages however the region doesn't know what page the user is on. The DomainHandler should only be loaded when the user can select a domain to limit the amount of updates.
Related branches
~ltrager/maas:lp1759525
- Blake Rouse (community): Approve
- MAAS Lander: Approve
-
Diff: 728 lines (+244/-159)10 files modifiedsrc/maasserver/static/js/angular/controllers/add_device.js (+9/-10)
src/maasserver/static/js/angular/controllers/add_hardware.js (+40/-42)
src/maasserver/static/js/angular/controllers/node_details.js (+3/-2)
src/maasserver/static/js/angular/controllers/nodes_list.js (+2/-2)
src/maasserver/static/js/angular/controllers/tests/test_add_device.js (+51/-21)
src/maasserver/static/js/angular/controllers/tests/test_add_hardware.js (+108/-59)
src/maasserver/static/js/angular/controllers/tests/test_node_details.js (+6/-7)
src/maasserver/static/js/angular/controllers/tests/test_nodes_list.js (+3/-3)
src/maasserver/static/js/angular/factories/general.js (+1/-1)
src/maasserver/static/js/angular/services/managerhelper.js (+21/-12)
| summary: |
- Domain handler sends update to all pages with controller loaded + [2.4, websockets] Domain handler sends update to all pages with + controller loaded |
| Changed in maas: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Lee Trager (ltrager) |
| Changed in maas: | |
| milestone: | 2.4.0beta2 → 2.4.0rc1 |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| milestone: | 2.4.0rc1 → 2.4.0beta3 |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
