IPMI auto-detection fails when LAN channel != 1

[Christopher Berner]

I have a ASUS RS400-E8-PS2, which has 2 LAN ports for management. One dedicated to the BMC, and one that's shared with the OS's LAN1. The dedicated one is mapped to LAN channel 1, and the shared one is mapped to LAN channel 8. If I use the dedicated port, MaaS automatic enlistment works fine. However, when trying to use the shared port it fails, because bmc-config returns 0.0.0.0 for the IP address, unless --lan-channel=8 is used.

[Christopher Berner (cberner)]

Let me know if you have any feedback on this fix. First time contributing to MAAS, so hope I did it right

[Newell Jensen (newell-jensen)]

Christopher,

Seems you have signed the contributor agreement if I am not mistaken? Since you wrote the code, how do you feel about creating a pull request and getting this patch reviewed by the MAAS team?

If you are up for it, take a look here:

https://code.launchpad.net/maas/+git

Let us know if you have any questions.

Thanks

[Christopher Berner (cberner)]

Sure, will do! Just cleaning up a couple more edge cases I found while testing on my hardware

[Dmitrii Shcherbakov (dmitriis)]

Christopher,

From the git workflow perspective with launchpad you would need to:

1) clone a git repository locally
2) make your changes
3) create a merge proposal

➜ testrepo git init
Initialized empty Git repository in /tmp/testrepo/.git/

➜ testrepo git:(master) ✗ touch testfile && git add testfile && git commit -m 'testcommit'
[master (root-commit) 4b8cb6c] testcommit
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 testfile

➜ testrepo git:(master) git push --set-upstream git+ssh://git.launchpad.net/~cberner/+git/testrepo master
Counting objects: 3, done.
Writing objects: 100% (3/3), 221 bytes | 221.00 KiB/s, done.
Total 3 (delta 0), reused 0 (delta 0)
To git+ssh://git.launchpad.net/~cberner/+git/testrepo
 * [new branch] master -> master
Branch master set up to track remote branch master from git+ssh://git.launchpad.net/~cberner/+git/testrepo.

This will create a repository under https://code.launchpad.net/~cberner/+git

https://code.launchpad.net/~cberner/+git/testrepo - this will be your personal project URL.

After that you can go to

https://code.launchpad.net/~cberner/+git/testrepo/+edit

And change the project "target" from "Personal" to "Project" and search for, e.g., "maas". In this example I will use "testrepo" as a target project instead.

As a result your repo URL will look like this: https://code.launchpad.net/~cberner/testrepo/+git/testrepo

This is because of how launchpad URLs are structured - lp is project-oriented

https://help.launchpad.net/Code/Git#Repository_URLs

https://code.launchpad.net/~OWNER/+git/REPOSITORY

You can then create a merge proposal either via web ui or by visiting a URL directly:

https://code.launchpad.net/~cberner/testrepo/+git/testrepo/+ref/master/+register-merge

Normally, before creating merge proposals, you also create a feature branch so that your own repo is structured and you can track multiple merge proposals in different branches.

You can see how other people use the same approach:

https://code.launchpad.net/~bjornt/maas/+git/maas

I hope that helps.

[Mike Pontillo (mpontillo)]

@cberner, to expand on Newell's comment about the contributor agreement, it is available here:

https://www.ubuntu.com/legal/contributors/submit

I think this will show up in Launchpad under the "Memberships" section once it has been verified.

I see you've already signed the Code of Conduct, which is great - thanks.

[Christopher Berner (cberner)]

Thanks! Hope I did this correctly: https://code.launchpad.net/~cberner/maas/+git/maas/+merge/336024

[Newell Jensen (newell-jensen)]

You will need to link the bug to the pull request by doing adding a commit message of the form mentioned here:

https://help.launchpad.net/Code/Git

See the section "Linking to bugs" for details.

[Adam Collard (adam-collard)]

This bug has not seen any activity in the last 6 months, so it is being automatically closed.

If you are still experiencing this issue, please feel free to re-open.

MAAS Team