[2.3, HWTv2] Incorrect overall status messages about failed tests
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
High
|
Lee Trager | ||
Bug Description
I added a new machine with an invalid password for the BMC (the BMC was reacheable though).
MAAS tried to add the machine just fine and start the commissioning process, but the machine effectively transitioned to failed commissioning provided that it couldn't really powered on.
So the UI showed a couple of errors:
1. For the disks, it showed "1 test has failed"
2. Fro the overall status, it showed "13 tests have failed"
So I see two issues with this:
1. MAAS never really started commissioning, and the scripts were never really run, so there's no reason why it should show as failed when in reality, the disk test never really failed.
2. The overall health status shows "13 tests have failed". There's two issues with this:
2.1. This is showing 13 tests incorrectly, as it refers to commissioning scripts, which shouldn't be showing.
2.2. The scripts were never run, so they never really fail.
Related branches
- Mike Pontillo (community): Approve
- MAAS Lander: Approve
-
Diff: 321 lines (+200/-22)5 files modifiedsrc/maasserver/static/js/angular/directives/machines_table.js (+41/-1)
src/maasserver/static/js/angular/directives/tests/test_machines_table.js (+108/-0)
src/maasserver/static/partials/machines-table.html (+4/-4)
src/maasserver/websockets/handlers/machine.py (+24/-9)
src/maasserver/websockets/handlers/tests/test_machine.py (+23/-8)
| Andres Rodriguez (andreserl) wrote | #1 |
| Changed in maas: | |
| assignee: | nobody → Lee Trager (ltrager) |
| importance: | Undecided → High |
| status: | New → Triaged |
| Lee Trager (ltrager) wrote | #2 |
| Changed in maas: | |
| status: | Triaged → Incomplete |
| Changed in maas: | |
| status: | Incomplete → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
This should be fixed with ~ltrager/