bond-lacp-rate set on any bond type

[Alvaro Uria]

MAAS version: 2.2.2 (6099-g8751f91-0ubuntu1~16.04.1)

From MAAS webUI, I configured a node with:
* bond0: 802.3ad + lacp-rate=fast
** bond0.XX: VLAN
* bond1: active-backup

When I deployed it, I found the following in dmesg:

[ 14.947707] bond1: option lacp_rate: mode dependency failed, not supported in mode active-backup(1)

In /etc/network/interfaces, I see that bond1 (and its slaves) have "bond-lacp-rate fast" as parameter, when only bond0 (and its slaves) should have it.

[Mike Pontillo (mpontillo)]

This needs further triage; I'm not sure if this is a MAAS issue or a curtin/cloud-init issue. It's likely that MAAS is passing the correct configuration, but it's being rendered incorrectly. I would need to test to confirm.

If you can attach the output of "maas $PROFILE machine get-curtin-config $SYSTEM_ID" for the machine with the misconfigured bonds, we can narrow down the problem.

[Mike Pontillo (mpontillo)]

Ah, I see the issue; MAAS will pass in the LACP rate regardless of bond type, and curtin/cloud-init will render it no matter what. So it seems none of the layers involved have logic to filter invalid combinations. I'll give this some thought to see if we can fix this in MAAS.