Curtin failure is not detected as an installation script failure
Bug #1701352 reported by
Lee Trager
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
Low
|
Lee Trager |
Bug Description
When Curtin signals its status using the status handler. On Curtin completion it includes a value with the Curtin output. MAAS stores this file as a script result. However Curtin doesn't include a return code so the default, 0, is used. When 0 is used MAAS assumes the script result passed. The machine is still put into failed_deployment, the script result needs to be failed as well.
Related branches
~ltrager/maas:lp1701352
Merged
into
maas:master
- MAAS Lander: Approve
- Blake Rouse (community): Approve
-
Diff: 158 lines (+73/-6)4 files modifiedsrc/metadataserver/api.py (+7/-2)
src/metadataserver/api_twisted.py (+7/-1)
src/metadataserver/tests/test_api.py (+22/-0)
src/metadataserver/tests/test_api_twisted.py (+37/-3)
Changed in maas: | |
milestone: | 2.3.0 → 2.3.x |
Changed in maas: | |
assignee: | nobody → Lee Trager (ltrager) |
milestone: | 2.3.x → 2.4.0rc2 |
status: | Triaged → In Progress |
milestone: | 2.4.0rc2 → 2.4.0rc1 |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
milestone: | 2.4.0rc1 → 2.4.0beta3 |
Changed in maas: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
can you provide more logs, information on how this is causing an error ? If the machine was marked failed deployment even though the curtin log was passed successfully, there may be a different reason why it was marked failed deployment.
For example, curtin may work successfully, but cloud-init failed and because of that, marked the machine as failed.
That said, this is a log, not a script result. As such, this should not be treated as one with status codes.