[2.1] dnsresources create fails on valid IP

[Kevin Metz]

running the following command

maas ubuntu dnsresources create fqdn=my.host.com ip_addresses=172.31.0.11
fails with the error

invalid literal for int() with base 10: '172.31.0.11'

[LaMont Jones (lamont)]

In the current code, forms/dnsresource.py's clean_ip converts a given IP address into a StaticIPAddress.id... if that fails, it happily leaves it as a string, and we die.

I played with a branch over the weekend that starts to address it, by creating the needed StaticIPAddress entries in save() if they do not exist.

[Craig Bender (craig-bender)]

ubuntu@OrangeBox20:~$ maas admin dnsresources create fqdn=host.ubuntu-cloud.archive.canonical.com ip_addresses=192.168.8.2
invalid literal for int() with base 10: '192.168.8.2'

ubuntu@OrangeBox20:~$ maas admin dnsresources create fqdn=host.ubuntu-cloud.archive.canonical.com
Success.
Machine-readable output follows:
{
    "fqdn": "host.ubuntu-cloud.archive.canonical.com",
    "resource_uri": "/MAAS/api/2.0/dnsresources/105/",
    "ip_addresses": [],
    "resource_records": [],
    "id": 105,
    "address_ttl": null
}

ubuntu@OrangeBox20:~$ maas admin dnsresources read|jq -r '.[]|select(.id==105)'
{
  "fqdn": "host.ubuntu-cloud.archive.canonical.com",
  "resource_uri": "/MAAS/api/2.0/dnsresources/105/",
  "ip_addresses": [],
  "resource_records": [],
  "id": 105,
  "address_ttl": null
}
ubuntu@OrangeBox20:~$ maas admin dnsresource update 105 ip_addresses=192.168.8.2
invalid literal for int() with base 10: '192.168.8.2'

[Billy Olsen (billy-olsen)]

Confirmed that this exists in 2.1.5 and is fixed in the ppa:maas/proposed package 2.1.6 for Xenial.