Activity log for bug #1659672

Date Who What changed Old value New value Message
2017-01-26 22:21:28 Andres Rodriguez bug added bug
2017-01-26 22:21:34 Andres Rodriguez maas: importance Undecided Critical
2017-01-26 22:21:36 Andres Rodriguez maas: status New Confirmed
2017-01-26 22:21:43 Andres Rodriguez maas: assignee Lee Trager (ltrager)
2017-01-26 22:24:25 Andres Rodriguez description I had the following machines: (1) Deployed (2) Failed deployment I upgraded to latest trunk rev5670 from a version that didn't use the new 'script' work. After trying to releasing, I see the following issue: Steps to reproduce ================== 1. Install MAAS 2.1 2. Deploy machine 3. Upgrade to latest trunk rev5670 4. Release the machine. ==> /var/log/maas/regiond.log <== 2017-01-26 17:19:03 maasserver.websockets.protocol: [critical] Error on request (87) machine.action: {"current_installation_script_set": ["script set instance with id 7 does not exist."]} Traceback (most recent call last): File "/usr/lib/python3.5/threading.py", line 862, in run self._target(*self._args, **self._kwargs) File "/usr/lib/python3/dist-packages/provisioningserver/utils/twisted.py", line 824, in worker return target() File "/usr/lib/python3/dist-packages/twisted/_threads/_threadworker.py", line 46, in work task() File "/usr/lib/python3/dist-packages/twisted/_threads/_team.py", line 190, in doWork task() --- <exception caught here> --- File "/usr/lib/python3/dist-packages/twisted/python/threadpool.py", line 246, in inContext result = inContext.theWork() File "/usr/lib/python3/dist-packages/twisted/python/threadpool.py", line 262, in <lambda> inContext.theWork = lambda: context.call(ctx, func, *args, **kw) File "/usr/lib/python3/dist-packages/twisted/python/context.py", line 118, in callWithContext return self.currentContext().callWithContext(ctx, func, *args, **kw) File "/usr/lib/python3/dist-packages/twisted/python/context.py", line 81, in callWithContext return func(*args,**kw) File "/usr/lib/python3/dist-packages/provisioningserver/utils/twisted.py", line 857, in callInContext return func(*args, **kwargs) File "/usr/lib/python3/dist-packages/provisioningserver/utils/twisted.py", line 225, in wrapper result = func(*args, **kwargs) File "/usr/lib/python3/dist-packages/maasserver/utils/orm.py", line 685, in call_within_transaction return func_outside_txn(*args, **kwargs) File "/usr/lib/python3/dist-packages/maasserver/utils/orm.py", line 503, in retrier return func(*args, **kwargs) File "/usr/lib/python3.5/contextlib.py", line 30, in inner return func(*args, **kwds) File "/usr/lib/python3/dist-packages/maasserver/websockets/handlers/machine.py", line 720, in action return action.execute(**extra_params) File "/usr/lib/python3/dist-packages/maasserver/node_action.py", line 395, in execute secure_erase=secure_erase, quick_erase=quick_erase) File "/usr/lib/python3/dist-packages/maasserver/models/node.py", line 2500, in release_or_erase self.release(user, comment) File "/usr/lib/python3/dist-packages/maasserver/models/node.py", line 2394, in release self._release(user) File "/usr/lib/python3/dist-packages/maasserver/models/node.py", line 2465, in _release self._finalize_release() File "/usr/lib/python3/dist-packages/maasserver/utils/orm.py", line 669, in call_within_transaction return func_within_txn(*args, **kwargs) File "/usr/lib/python3.5/contextlib.py", line 30, in inner return func(*args, **kwds) File "/usr/lib/python3/dist-packages/maasserver/models/node.py", line 2483, in _finalize_release self.save() File "/usr/lib/python3/dist-packages/maasserver/models/node.py", line 1522, in save super(Node, self).save(*args, **kwargs) File "/usr/lib/python3/dist-packages/maasserver/models/cleansave.py", line 28, in save self.full_clean() File "/usr/lib/python3/dist-packages/django/db/models/base.py", line 1171, in full_clean raise ValidationError(errors) django.core.exceptions.ValidationError: {'current_installation_script_set': ['script set instance with id 7 does not exist.']} I had the following machines: a. (1) Deployed b. (2) Failed deployment c. (3) Ready I upgraded to latest trunk rev5670 from a version that didn't use the new 'script' work. 1. After trying to release (a) and (b), I see the issue below (both in UI and traceback). 2. I tried to deploy (3) and then try to release, see the same issue. However, I clicked on 'retry' and it released fine this time. Steps to reproduce ================== 1. Install MAAS 2.1 2. Deploy machine 3. Upgrade to latest trunk rev5670 4. Release the machine. ==> /var/log/maas/regiond.log <== 2017-01-26 17:19:03 maasserver.websockets.protocol: [critical] Error on request (87) machine.action: {"current_installation_script_set": ["script set instance with id 7 does not exist."]} Traceback (most recent call last):   File "/usr/lib/python3.5/threading.py", line 862, in run     self._target(*self._args, **self._kwargs)   File "/usr/lib/python3/dist-packages/provisioningserver/utils/twisted.py", line 824, in worker     return target()   File "/usr/lib/python3/dist-packages/twisted/_threads/_threadworker.py", line 46, in work     task()   File "/usr/lib/python3/dist-packages/twisted/_threads/_team.py", line 190, in doWork     task() --- <exception caught here> ---   File "/usr/lib/python3/dist-packages/twisted/python/threadpool.py", line 246, in inContext     result = inContext.theWork()   File "/usr/lib/python3/dist-packages/twisted/python/threadpool.py", line 262, in <lambda>     inContext.theWork = lambda: context.call(ctx, func, *args, **kw)   File "/usr/lib/python3/dist-packages/twisted/python/context.py", line 118, in callWithContext     return self.currentContext().callWithContext(ctx, func, *args, **kw)   File "/usr/lib/python3/dist-packages/twisted/python/context.py", line 81, in callWithContext     return func(*args,**kw)   File "/usr/lib/python3/dist-packages/provisioningserver/utils/twisted.py", line 857, in callInContext     return func(*args, **kwargs)   File "/usr/lib/python3/dist-packages/provisioningserver/utils/twisted.py", line 225, in wrapper     result = func(*args, **kwargs)   File "/usr/lib/python3/dist-packages/maasserver/utils/orm.py", line 685, in call_within_transaction     return func_outside_txn(*args, **kwargs)   File "/usr/lib/python3/dist-packages/maasserver/utils/orm.py", line 503, in retrier     return func(*args, **kwargs)   File "/usr/lib/python3.5/contextlib.py", line 30, in inner     return func(*args, **kwds)   File "/usr/lib/python3/dist-packages/maasserver/websockets/handlers/machine.py", line 720, in action     return action.execute(**extra_params)   File "/usr/lib/python3/dist-packages/maasserver/node_action.py", line 395, in execute     secure_erase=secure_erase, quick_erase=quick_erase)   File "/usr/lib/python3/dist-packages/maasserver/models/node.py", line 2500, in release_or_erase     self.release(user, comment)   File "/usr/lib/python3/dist-packages/maasserver/models/node.py", line 2394, in release     self._release(user)   File "/usr/lib/python3/dist-packages/maasserver/models/node.py", line 2465, in _release     self._finalize_release()   File "/usr/lib/python3/dist-packages/maasserver/utils/orm.py", line 669, in call_within_transaction     return func_within_txn(*args, **kwargs)   File "/usr/lib/python3.5/contextlib.py", line 30, in inner     return func(*args, **kwds)   File "/usr/lib/python3/dist-packages/maasserver/models/node.py", line 2483, in _finalize_release     self.save()   File "/usr/lib/python3/dist-packages/maasserver/models/node.py", line 1522, in save     super(Node, self).save(*args, **kwargs)   File "/usr/lib/python3/dist-packages/maasserver/models/cleansave.py", line 28, in save     self.full_clean()   File "/usr/lib/python3/dist-packages/django/db/models/base.py", line 1171, in full_clean     raise ValidationError(errors) django.core.exceptions.ValidationError: {'current_installation_script_set': ['script set instance with id 7 does not exist.']}
2017-01-26 22:25:34 Andres Rodriguez summary [2.1, rev5670] Can't release machines previously deployed/failed deployment after upgrade to latest trunk [2.1, rev5670] Can't release machines previously deployed/failed deployment/or newly deployed after upgrade to latest trunk
2017-01-26 22:26:39 Jason Hobbs tags oil oil-2.0
2017-01-26 22:36:06 Jason Hobbs tags oil oil-2.0 cdo-qa-blocker oil oil-2.0
2017-01-26 22:43:44 Andres Rodriguez maas: status Confirmed In Progress
2017-01-27 08:45:32 Launchpad Janitor branch linked lp:~ltrager/maas/dont_delete_installation_script_set
2017-01-27 16:04:01 Andres Rodriguez branch linked lp:~allenap/maas/clear-installation-script-set-on-release
2017-01-27 16:05:32 Andres Rodriguez maas: status In Progress Fix Committed
2017-01-27 16:05:34 Andres Rodriguez maas: milestone 2.2.0
2017-01-27 16:05:42 Andres Rodriguez maas: assignee Lee Trager (ltrager) Gavin Panella (allenap)
2017-03-15 09:09:59 Andres Rodriguez maas: status Fix Committed Fix Released