[UI] status messages on the Nodes page are in the wrong tense

Bug #1629430 reported by Brendan Donegan
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Critical
Newell Jensen

Bug Description

I've noticed that status messages displayed on the Nodes page when multiple nodes are selected, are in the wrong tense. For example, after selecting several New nodes and asking them to Commision, the status message is '2 out of 4 nodes are commissioned'. They are *being* commissioned, but aren't yet in fact.

Related branches

Revision history for this message
Brendan Donegan (brendan-donegan) wrote :
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

the example above is for deploying but the same issue is present for commissioning

Changed in maas:
milestone: none → 2.1.0
importance: Undecided → Critical
Revision history for this message
Blake Rouse (blake-rouse) wrote :

Critical for wording? I think the Critical importance is being heavily abused.

Revision history for this message
Andres Rodriguez (andreserl) wrote : Re: [Bug 1629430] [NEW] [UI] status messages on the Nodes page are in the wrong tense

If we don't do a good job at putting good wording or at reviewing branches
 hay introduce user facing wording then yes this needs to be fixed
critically.

More and more I'm finding places where the wording has reduced in quality
significantly and we need to fix that ASAP. This includes user facing
wording as well as code documentation and API documentation.

So yes, this being the case, I'm gonna start pushing for I creasing the
quality of this. I don't wanna make the same mistakes done in the past.

On Friday, September 30, 2016, Blake Rouse <email address hidden>
wrote:

> Critical for wording? I think the Critical importance is being heavily
> abused.
>
> --
> You received this bug notification because you are subscribed to MAAS.
> https://bugs.launchpad.net/bugs/1629430
>
> Title:
> [UI] status messages on the Nodes page are in the wrong tense
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/maas/+bug/1629430/+subscriptions
>

--
Andres Rodriguez (RoAkSoAx)
Ubuntu Server Developer
MSc. Telecom & Networking
Systems Engineer

Changed in maas:
status: New → Triaged
Changed in maas:
milestone: 2.1.0 → 2.1.1
Changed in maas:
milestone: 2.1.1 → 2.1.2
Changed in maas:
assignee: nobody → Newell Jensen (newell-jensen)
Changed in maas:
status: Triaged → In Progress
Changed in maas:
status: In Progress → Fix Committed
Changed in maas:
status: Fix Committed → Fix Released
Revision history for this message
Christian Reis (kiko) wrote :

Ironically, this actually didn't help.

The text now says "N nodes are transitioning to commissioned". But that doesn't make sense either! Saner options:

  - "N nodes are being commissioned" (though I don't know if that works for the other actions)
  - "N nodes have started commissioning"
  - "N nodes will be commissioned"
  - "Commissioning N nodes"

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.