dns_servers and ntp_servers in _ConfigureDHCP are defined as strings
Bug #1606264 reported by
Gavin Panella
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Medium
|
Gavin Panella | ||
Bug Description
dns_servers and ntp_servers should be defined as lists proper; right now it's unclear if they are space- or comma-separated strings or both or either. ISC dhcpd likes comma-separated lists only, so it's important to render the correct thing, and starting from a list makes it clearer what operation is necessary.
Related branches
lp:~allenap/maas/configure-dhcp-v2-rack--bug-1606264
- Mike Pontillo (community): Approve
-
Diff: 652 lines (+257/-38)9 files modifiedsrc/maasserver/dhcp.py (+1/-1)
src/maasserver/tests/test_dhcp.py (+6/-6)
src/provisioningserver/dhcp/config.py (+12/-5)
src/provisioningserver/dhcp/testing/config.py (+22/-6)
src/provisioningserver/dhcp/tests/test_config.py (+3/-3)
src/provisioningserver/rpc/cluster.py (+121/-10)
src/provisioningserver/rpc/clusterservice.py (+36/-2)
src/provisioningserver/rpc/dhcp.py (+19/-0)
src/provisioningserver/rpc/tests/test_clusterservice.py (+37/-5)
lp:~allenap/maas/configure-dhcp-v2-region--bug-1606264
- Mike Pontillo (community): Approve
-
Diff: 865 lines (+274/-111)5 files modifiedsrc/maasserver/dhcp.py (+84/-31)
src/maasserver/tests/test_dhcp.py (+168/-73)
src/provisioningserver/rpc/clusterservice.py (+4/-4)
src/provisioningserver/rpc/dhcp.py (+17/-2)
src/provisioningserver/rpc/tests/test_clusterservice.py (+1/-1)
Revision history for this message
| Gavin Panella (allenap) wrote | #1 |
| Changed in maas: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Gavin Panella (allenap) |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
I inadvertently changed the base _ConfigureDHCP RPC call to use "ntp_servers" instead of "ntp_server" without creating a new RPC call version, so I'm going to fix both bugs at the same time.