Spurious failure in TestIPRangeSavePreventsOverlapping.test__dynamic_range_cannot_overlap_most_ip_types

[Gavin Panella]

I was able to reproduce this by looping a test run:

  while bin/test.region maasserver.models.tests.test_iprange:TestIPRangeSavePreventsOverlapping; do true; done

It fails about 1 time in 10 or 20 at a guess.

Traceback (most recent call last):
  File ".../src/maastesting/runtest.py", line 135, in _run_user
    result = function(*args, **kwargs)
  File ".../testtools/testcase.py", line 714, in _run_test_method
    return self._get_test_method()()
  File ".../src/maasserver/models/tests/test_iprange.py", line 469, in
  test__dynamic_range_cannot_overlap_most_ip_types
    iprange.save()
  File ".../testtools/testcase.py", line 1018, in __exit__
    raise AssertionError(error_msg)
AssertionError: ValidationError not raised.

[Gavin Panella (allenap)]

Also:

FAIL: maasserver.models.tests.test_iprange.TestIPRangeSavePreventsOverlapping.test__dynamic_range_cannot_overlap_most_ip_types
----------------------------------------------------------------------
Traceback (most recent call last):
testtools.testresult.real._StringException: Empty attachments:
  Twisted logs

Traceback (most recent call last):
  File "/tmp/tarmac/branch.lCCWfW/src/maasserver/models/tests/test_iprange.py", line 483, in test__dynamic_range_cannot_overlap_most_ip_types
    iprange.save()
  File "/tmp/tarmac/branch.lCCWfW/src/maasserver/models/cleansave.py", line 28, in save
    self.full_clean()
  File "/usr/lib/python3/dist-packages/django/db/models/base.py", line 1171, in full_clean
    raise ValidationError(errors)
django.core.exceptions.ValidationError: {'type': ['No dynamic range can be created at requested start IP.'], 'start_ip': ['No dynamic range can be created at requested start IP.']}

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/tmp/tarmac/branch.lCCWfW/src/maastesting/runtest.py", line 134, in _run_user
    result = function(*args, **kwargs)
  File "/home/ubuntu/.buildout/eggs/testtools-2.2.0-py3.5.egg/testtools/testcase.py", line 719, in _run_test_method
    return self._get_test_method()()
  File "/tmp/tarmac/branch.lCCWfW/src/maasserver/models/tests/test_iprange.py", line 483, in test__dynamic_range_cannot_overlap_most_ip_types
    iprange.save()
  File "/home/ubuntu/.buildout/eggs/testtools-2.2.0-py3.5.egg/testtools/testcase.py", line 1032, in __exit__
    raise AssertionError(mismatch.describe())
AssertionError: "{'type': ['No dynamic range can be created at requested start IP.'], 'start_ip': ['No dynamic range can be created at requested start IP.']}" does not match /.*Requested dynamic range conflicts with an existing IP address or range.*/

[Gavin Panella (allenap)]

I'm disabling this test.

[Mike Pontillo (mpontillo)]

Closing this, since this test no longer exists.