twisted's conch does not support ed25519 and ecdsa ssh public keys

Bug #1590081 reported by William on 2016-06-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Undecided
Gavin Panella
twisted (Ubuntu)
Undecided
Unassigned

Bug Description

When adding public keys to a user account, ed25519 and ecdsa public keys are showing as not supported public key types; the UI presents "Invalid SSH public key" as feedback.

Related branches

summary: when setting up ssh accounts for the key injection, allow specifying
- ed25519 public keys
+ ed25519 and ecdsa public keys
description: updated
description: updated
description: updated
Changed in maas:
milestone: none → 2.0.0
Christian Reis (kiko) on 2016-06-07
description: updated
Changed in maas:
milestone: 2.0.0 → 2.1.0

In /usr/lib/python3/dist-packages/twisted/conch/ssh/keys.py, fromString does not support ed25519 and ecdsa keys.

affects: maas → twisted (Ubuntu)
Changed in twisted (Ubuntu):
milestone: 2.1.0 → none
affects: twisted (Ubuntu) → maas
Changed in maas:
milestone: none → 2.1.0
summary: - when setting up ssh accounts for the key injection, allow specifying
- ed25519 and ecdsa public keys
+ twisted's conch does not support ed25519 and ecdsa ssh public keys
LaMont Jones (lamont) wrote :

2016-06-08 13:01:15 [maasserver] ERROR: Invalid SSH public key
Traceback (most recent call last):
  File "/usr/lib/python3/dist-packages/maasserver/models/sshkey.py", line 41, in validate_ssh_public_key
    key = Key.fromString(value.encode("utf-8"))
  File "/usr/lib/python3/dist-packages/twisted/conch/ssh/keys.py", line 118, in fromString
    raise BadKeyError('cannot guess the type of %r' % (data,))
twisted.conch.ssh.keys.BadKeyError: cannot guess the type of b'ecdsa-sha2-nistp256 AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBKHbdCD8RGTwodwdKnfnd6xOBjRMsh9AL+FTeSst2T9IkEeMhKr/dEr7mzFdHzkS1XvdpYCxQxJ4R5Ik4HCONLM= lamont@tigernut'

Changed in twisted (Ubuntu):
status: New → Confirmed
Changed in maas:
status: New → Triaged
Matthias Klose (doko) wrote :

please forward this upstream

Gavin Panella (allenap) on 2016-06-10
Changed in maas:
status: Triaged → In Progress
assignee: nobody → Gavin Panella (allenap)
Changed in maas:
milestone: 2.1.0 → 2.0.0
Changed in maas:
status: In Progress → Fix Committed
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers