[2.0b5] No form validation when adding a subnet, space, fabric or vlan

Bug #1588298 reported by Richard McCartney on 2016-06-02
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Critical
Blake Rouse

Bug Description

When adding or trying to add a space or subnet if there is a duplicated name there is no form validation similar to network details stating you were unsuccessful.

Current result:
Given I’m on networks listing page
When I try to add a space with a name that already exists in the table
Then I am able to add it, no error is generated

Expected/ correct result:
Given I’m on networks listing page
When I try to add a space with a name that already exists
Then I am unable to add it, I receive an error message and the form input field should outline in red
And disable “Add space” button in error mode

With the current behaviour it is unclear to the user if a space with duplicate name has been added as there’s no indication of otherwise but also there’s no record in the spaces table.

Tags: ui ux Edit Tag help

Related branches

summary: - No form validation when adding a subnet, space, fabric or vlan
+ [2.0b5] No form validation when adding a subnet, space, fabric or vlan
Mike Pontillo (mpontillo) wrote :

That's interesting. I tried to add "space-0" and observed that nothing seemed to happen. I switched the "Group by" box to "Spaces", then observed that there was a "space-1". I then added "space-1" and saw "space-2" sprint into existence.

So that's weird, but even worse: I then added a space called "puppies". It created "space-3". Likewise, creating a corresponding "kittens" space created "space-4".

So it seems this form isn't properly passing the name through, and a default name is being used instead.

Changed in maas:
importance: Undecided → Medium
status: New → Triaged
milestone: none → 2.0.0
importance: Medium → Critical
LaMont Jones (lamont) on 2016-06-02
Changed in maas:
assignee: nobody → LaMont Jones (lamont)
Blake Rouse (blake-rouse) wrote :

To get validation this should be converted to use maas-obj-form directive.

LaMont Jones (lamont) on 2016-06-08
Changed in maas:
assignee: LaMont Jones (lamont) → Blake Rouse (blake-rouse)
Changed in maas:
status: Triaged → In Progress
Changed in maas:
status: In Progress → Fix Committed
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers