[2.0b5] In p.rpc.clusterservice.Cluster.refresh, nothing waits for or handles errors from p.refresh.refresh
Bug #1587549 reported by
Gavin Panella
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Medium
|
Lee Trager | ||
Bug Description
In the following code:
d = deferToThread(
refresh, system_id, consumer_key, token_key, token_secret)
d.addErrbac
(`d` is reassigned later, before being referenced.)
Related branches
lp:~ltrager/maas/refresh_locking
- Blake Rouse (community): Approve
- Gavin Panella (community): Approve
-
Diff: 483 lines (+245/-76)6 files modifiedsrc/maasserver/models/node.py (+70/-29)
src/maasserver/models/tests/test_node.py (+79/-43)
src/provisioningserver/rpc/cluster.py (+4/-1)
src/provisioningserver/rpc/clusterservice.py (+14/-3)
src/provisioningserver/rpc/exceptions.py (+5/-0)
src/provisioningserver/rpc/tests/test_clusterservice.py (+73/-0)
| summary: |
- In p.rpc.clusterservice.Cluster.refresh, nothing waits for or handles - errors from p.refresh.refresh + [2.0b5] In p.rpc.clusterservice.Cluster.refresh, nothing waits for or + handles errors from p.refresh.refresh |
| Changed in maas: | |
| status: | Triaged → Fix Committed |
| assignee: | nobody → Lee Trager (ltrager) |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
