[2.0b5] In p.rpc.clusterservice.Cluster.refresh, no attempt is made to deal with concurrency
Bug #1587548 reported by
Gavin Panella
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Critical
|
Lee Trager | ||
Bug Description
The region can make multiple calls to this RPC responder and nothing is
done in either the region or the rack to limit concurrency here.
Identical duplicate concurrent requests should be discarded, and other
concurrent requests should be queued or rejected.
Related branches
lp:~ltrager/maas/refresh_locking
- Blake Rouse (community): Approve
- Gavin Panella (community): Approve
-
Diff: 483 lines (+245/-76)6 files modifiedsrc/maasserver/models/node.py (+70/-29)
src/maasserver/models/tests/test_node.py (+79/-43)
src/provisioningserver/rpc/cluster.py (+4/-1)
src/provisioningserver/rpc/clusterservice.py (+14/-3)
src/provisioningserver/rpc/exceptions.py (+5/-0)
src/provisioningserver/rpc/tests/test_clusterservice.py (+73/-0)
| summary: |
- In p.rpc.clusterservice.Cluster.refresh, no attempt it made to deal with + In p.rpc.clusterservice.Cluster.refresh, no attempt is made to deal with concurrency |
| summary: |
- In p.rpc.clusterservice.Cluster.refresh, no attempt is made to deal with - concurrency + [2.0b5] In p.rpc.clusterservice.Cluster.refresh, no attempt is made to + deal with concurrency |
| Changed in maas: | |
| status: | New → In Progress |
| assignee: | nobody → Gavin Panella (allenap) |
| Changed in maas: | |
| assignee: | Gavin Panella (allenap) → Lee Trager (ltrager) |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
