[UI 2.0b1] Impossible to change subnet CIDR or gateway with instant editing

Bug #1572076 reported by Carla Berkers on 2016-04-19
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
High
Blake Rouse

Bug Description

Bug:
When the new instant editing functionality implemented, users can change editable values by 1. clicking the info, which activates the form field. 2. editing the info in the form field. 3. clicking outside the form field to save.

This isn't possible on the subnet details on the CIDR and Gateway IP fields. When a user changes and clicks outside the CIDR field, it will validate and not save because CIDR and Gateway need to be in the same subnet. Same problem occurs if a user tries to change the Gateway, that won't save because the CIDR isn't on the same subnet (and the new CIDR isn't saved).

Suggested solution:
Link the form fields so they validate as a pair, similar to the form fields for changing your password and then confirming the new password. Ideal behavior in the attached sketch:
1. on page load
- change order of fields to Name, CIDR, Gateway IP, DNS
- change DNS placeholder text to "DNS provider for this subnet"

2. on hover of a single item (for instance name)
- make form background white
- make outline darker grey
- on click: same style as on hover

3. on hover for linked fields (CIDR or Gateway IP)
- hovering one field will show the hover state on both fields at the same time
- on click: will activate both fields at the same time

4. on edit
- users can edit both fields and switch between the two fields without validating.
- when users click outside of either field both will validate at the same time.

5. on save
- if gateway and CIDR are not on the same subnet when the user clicks outside the fields, the outlines of both fields will become red
- an error will appear in red below the Gateway field: "Gateway IP address must be on the subnet CIDR"
- when a user leaves the page and later returns, the error style and text should remain visible

Related branches

Carla Berkers (carlaberkers) wrote :
Blake Rouse (blake-rouse) wrote :

Looks really good. Thanks for the details explanation this will really help with the implementation.

The only issue I see is:

- when a user leaves the page and later returns, the error style and text should remain visible

The subnet cannot be saved until both values are correct so if you leave the page and come back they will just be set back to the original values. This is the same way it works across all of MAAS and many other applications.

Changed in maas:
status: New → Triaged
importance: Undecided → High
milestone: none → 2.0.0
Changed in maas:
assignee: nobody → Richard McCartney (ricgard)
Changed in maas:
status: Triaged → In Progress
assignee: Richard McCartney (ricgard) → Blake Rouse (blake-rouse)
Changed in maas:
status: In Progress → Fix Committed
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments