MAAS

[2.0a1] bridges with same mac as physical interfaces prevent rack interface discovery

Bug #1555679 reported by LaMont Jones
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
Critical
Mike Pontillo
MAAS 2.0.0

Bug Description

I have the following setup on my maas test host, and maas gets very lost, filling the log with the attached.

Related branches

lp:~mpontillo/maas/bridge-interface-model-and-region-contract
Blake Rouse (community): Approve
Diff: 2189 lines (+1258/-242)
21 files modified
src/maasserver/api/tests/test_interfaces.py (+2/-2)
src/maasserver/enum.py (+2/-0)
src/maasserver/forms_interface.py (+131/-73)
src/maasserver/migrations/builtin/maasserver/0046_add_bridge_interface_type.py (+44/-0)
src/maasserver/models/__init__.py (+2/-0)
src/maasserver/models/interface.py (+154/-33)
src/maasserver/models/node.py (+90/-58)
src/maasserver/models/signals/interfaces.py (+7/-5)
src/maasserver/models/signals/tests/test_interfaces.py (+8/-3)
src/maasserver/models/tests/test_interface.py (+122/-2)
src/maasserver/models/tests/test_node.py (+388/-1)
src/maasserver/static/js/angular/controllers/node_details_networking.js (+20/-15)
src/maasserver/static/js/angular/controllers/tests/test_node_details_networking.js (+83/-6)
src/maasserver/static/partials/node-details.html (+1/-1)
src/maasserver/testing/factory.py (+3/-0)
src/maasserver/tests/test_forms_interface.py (+190/-3)
src/provisioningserver/utils/__init__.py (+0/-3)
src/provisioningserver/utils/ipaddr.py (+1/-12)
src/provisioningserver/utils/network.py (+6/-0)
src/provisioningserver/utils/tests/test_ipaddr.py (+1/-23)
src/provisioningserver/utils/tests/test_network.py (+3/-2)
lp:~mpontillo/maas/fix-bridges-on-vlans-1555679
Gavin Panella (community): Approve
Blake Rouse (community): Approve
Diff: 958 lines (+541/-182)
6 files modified
src/maasserver/models/interface.py (+57/-25)
src/maasserver/models/node.py (+0/-14)
src/maasserver/models/signals/interfaces.py (+24/-4)
src/maasserver/models/signals/tests/test_interfaces.py (+23/-5)
src/maasserver/models/tests/test_interface.py (+56/-24)
src/maasserver/models/tests/test_node.py (+381/-110)
Revision history for this message
LaMont Jones (lamont) wrote :
Revision history for this message
LaMont Jones (lamont) wrote :
Andres Rodriguez (andreserl)
summary: - bridges on the rack controller prevent discovery
+ bridges with same mac as physical interfaces prevent rack interface
+ discovery
Revision history for this message
LaMont Jones (lamont) wrote :

We need to model bridges. Since eth0 is part of all the bridges (or one of its vlans), the mac address on all 3 bridges is the same as eth0 and eth0.*. This results in confusion.

summary: - bridges with same mac as physical interfaces prevent rack interface
- discovery
+ [2.0a1] bridges with same mac as physical interfaces prevent rack
+ interface discovery
Blake Rouse (blake-rouse)
Changed in maas:
status: New → Triaged
importance: Undecided → Critical
milestone: none → 2.0.0
Revision history for this message
LaMont Jones (lamont) wrote :

Note that in the config above, br0 does not have a vlan tag, but it's pretty clear that it's vid=3 (bridging disparate vlans would be pretty silly for the admin to do, so simply picking the vlan of the underlying tagged interface should be acceptable)

Though I suppose an argument could be made that I should only have br0, and configure br0 (since eth0 is untagged), and br0.3 and br0.4.

Revision history for this message
Mike Pontillo (mpontillo) wrote :

Agreed that we should model bridges.

Deriving physical interface VLAN tags from bridge configurations sounds like it might be a slippery slope, but it's an interesting idea. It seems like in this case we might erroneously create three fabrics, when we should really have just one.

Andres Rodriguez (andreserl)
Changed in maas:
assignee: nobody → Mike Pontillo (mpontillo)
MAAS Lander (maas-lander)
Changed in maas:
status: Triaged → Fix Committed
Mike Pontillo (mpontillo)
Changed in maas:
status: Fix Committed → In Progress
MAAS Lander (maas-lander)
Changed in maas:
status: In Progress → Fix Committed
Andres Rodriguez (andreserl)
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.