hover state on node networking no longer working (regression)

[Carla Berkers]

on the node details page on the network section, the editable fields and icons do not appear on hover.

this is a regression caused by a branch that landed yesterday.

I'm running MAAS 1.9.0 Beta 1 and FF 41.0.2.

[Andres Rodriguez (andreserl)]

Is your Machine on Ready state? If your machine is in deployed state you won't be able to see this. You can't change networking while the machine is deployed.

[Blake Rouse (blake-rouse)]

No even when it is redy you get this. You have to select the row first before you can edit anything. Which doesnt fit the storage pattern.

Which makes me wonder they are using the same CSS, why are they having different interactions?

[Richard McCartney (ricgard)]

Hey guys,

I noticed on each table row there was a class of 'selected'. Now this is usually caused by multiple selections, we have 3 classes being added via angular

data-ng-class="{ active: isInterfaceSelected(interface), disabled: isDisabled(), selected: !isOnlyInterfaceSelected(interface) }"

Looks like the last class call looks incorrect to me, removing the ! fixes the issue and all network interfaces can be hovered as usual, before I make a MP could there be any reason why this happened?

[Blake Rouse (blake-rouse)]

I would say it was just an accident somehow. I am sure we could look at the history of bzr to find the person, might have be me or you. I don't know.

Lets just get it landed, if that fixes the issue. Please push it for an MP.

[Andres Rodriguez (andreserl)]

I wonder if this is related: https://bugs.launchpad.net/maas/+bug/1511208

[Richard McCartney (ricgard)]

So talking to Blake and Carla this is the new interaction to happen on all table for storage and networking:

- IF no rows are selected hovering on a row shows any inputs and can be interacted with.
- If one row is selected that row can be edited. All other rows do not show the hover interaction and can not be edited.
- If two or more rows are selected nothing can be edited on the selected / non selected rows.

[Richard McCartney (ricgard)]

Ready for review.