[developer] Need a manual way to automatically discover virtual interfaces / bridges
Bug #1508746 reported by
Andres Rodriguez
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Opinion
|
High
|
Unassigned |
Bug Description
Now that MAAS only automatically discovers physical interfaces, vlan interfaces and bonds, we need a way for maas to automatically create virbr0/br0 interfaces as this is very helpful for developers.
Related branches
lp:~mpontillo/maas/autocreate-fabrics-and-vlans
- Blake Rouse (community): Approve
- LaMont Jones (community): Approve
-
Diff: 1069 lines (+553/-100)12 files modifiedsrc/maasserver/forms.py (+108/-50)
src/maasserver/models/fabric.py (+23/-0)
src/maasserver/models/nodegroupinterface.py (+2/-1)
src/maasserver/models/tests/test_nodegroupinterface.py (+12/-12)
src/maasserver/models/vlan.py (+8/-0)
src/maasserver/tests/test_forms_nodegroupinterface.py (+107/-2)
src/maasserver/utils/interfaces.py (+3/-1)
src/provisioningserver/network.py (+146/-17)
src/provisioningserver/rpc/clusterservice.py (+1/-0)
src/provisioningserver/tests/test_network.py (+33/-1)
src/provisioningserver/utils/ipaddr.py (+63/-4)
src/provisioningserver/utils/tests/test_ipaddr.py (+47/-12)
Changed in maas: | |
milestone: | none → 1.9.0 |
importance: | Undecided → High |
summary: |
- [develper] Need a manual way to automatically discover virtual + [developer] Need a manual way to automatically discover virtual interfaces / bridges |
Changed in maas: | |
status: | In Progress → Opinion |
Changed in maas: | |
assignee: | Mike Pontillo (mpontillo) → nobody |
To post a comment you must log in.
I'm not convinced we need another code change for this. Since this is for a dev/test use case, can't you just automate this with a script to call the API?
It would be possible to have an option to customize the filtering. But it would be likely that by the time "apt-get install" is finished and the default cluster registers with the region, it's too late to modify a special setting for this. (Unless no interfaces are being added at all; that's the only time re-registering causes any changes.)
I think the real solution to this is to separate state from configuration in the database. That is, when the state of the cluster interfaces is discovered and presented to MAAS, nothing should be configured (and thus become "configuration" rather than "state") until the user approves it. Right now, discovered interfaces are entered *directly* into the configuration, and *that* is the root cause of this bug. (you could compare this to, if you install BIND for the first time, if the first time you ran the daemon it suddenly decided to rewrite a bunch of your configuration files in /etc - that would be just plain wrong!)