[1.9.0 alpha3] change "(Default VLAN)" to "untagged"
Bug #1503529 reported by
Carla Berkers
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
High
|
Blake Rouse | ||
Bug Description
doesn't fit in the table and as discussed with Mark, default is a lot cleaner.
Related branches
lp:~blake-rouse/maas/fix-vlan-to-untagged
- Blake Rouse (community): Approve
- Mike Pontillo (community): Approve
-
Diff: 1262 lines (+742/-63)26 files modifiedsrc/maasserver/api/fabrics.py (+5/-0)
src/maasserver/api/tests/test_fabrics.py (+1/-11)
src/maasserver/api/tests/test_vlans.py (+3/-4)
src/maasserver/api/vlans.py (+6/-1)
src/maasserver/context_processors.py (+1/-0)
src/maasserver/fixtures/dev_fixture.yaml (+4/-4)
src/maasserver/forms_vlan.py (+8/-0)
src/maasserver/migrations/0183_remove_required_name_from_vlan_and_fabric.py (+519/-0)
src/maasserver/models/fabric.py (+8/-1)
src/maasserver/models/tests/test_fabric.py (+9/-0)
src/maasserver/models/tests/test_vlan.py (+9/-0)
src/maasserver/models/vlan.py (+10/-4)
src/maasserver/static/js/angular/controllers/node_details_networking.js (+28/-3)
src/maasserver/static/js/angular/controllers/subnets_list.js (+3/-1)
src/maasserver/static/js/angular/controllers/tests/test_node_details_networking.js (+58/-11)
src/maasserver/static/js/angular/filters/remove_default_vlan.js (+17/-0)
src/maasserver/static/js/angular/filters/tests/test_remove_default_vlan.js (+30/-0)
src/maasserver/static/partials/node-details.html (+6/-6)
src/maasserver/testing/factory.py (+0/-4)
src/maasserver/tests/test_forms_fabric.py (+0/-7)
src/maasserver/tests/test_forms_space.py (+2/-2)
src/maasserver/tests/test_forms_vlan.py (+11/-2)
src/maasserver/websockets/handlers/fabric.py (+1/-0)
src/maasserver/websockets/handlers/tests/test_fabric.py (+1/-1)
src/maasserver/websockets/handlers/tests/test_vlan.py (+1/-1)
src/maasserver/websockets/handlers/vlan.py (+1/-0)
Revision history for this message
| Blake Rouse (blake-rouse) wrote | #1 |
| Changed in maas: | |
| status: | New → Triaged |
| importance: | Undecided → High |
| assignee: | Blake Rouse (blake-rouse) → nobody |
| milestone: | none → 1.9.0 |
| tags: | added: networking |
Revision history for this message
| Blake Rouse (blake-rouse) wrote | #2 |
| summary: |
- [1.9.0 alpha3] change "(Default VLAN)" to "(default)" + [1.9.0 alpha3] change "(Default VLAN)" to "untagged" |
| Changed in maas: | |
| status: | Triaged → In Progress |
| assignee: | nobody → Blake Rouse (blake-rouse) |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
We should allow the name to be optional on VLAN's and add a flag to the VLAN model to mark it as the default VLAN. That will also make it easier to switch the default VLAN.