MAAS power query does not work for Python power drivers

Bug #1485677 reported by Andres Rodriguez on 2015-08-17
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Critical
Newell Jensen

Bug Description

The MAAS power querying mechanism is not working for the MAAS python power drivers. This was found right after landing the IPMI python power driver.

Related branches

Newell Jensen (newell-jensen) wrote :

Andres,

Can you please let me know what the error is. Using the same code that was reverted, I do not get any power query errors/issues on the hardware that I have been testing on.

Thanks.

Changed in maas:
assignee: nobody → Newell Jensen (newell-jensen)
Changed in maas:
importance: Undecided → Critical
milestone: none → 1.9.0
Gavin Panella (allenap) wrote :

For IPMI at least, the problem appears to be bad data. Power parameters
are stored in the power_parameters JSON field on the Node.

* If no choice is made for the "Power driver" field in the UI, the value
  stored for "power_driver" is the following *list*:

    ["LAN_2_0", "LAN_2_0 [IPMI 2.0]"]

* Once "LAN_2_0 [IPMI 2.0]" is selected in the UI, "power_driver" is set
  to the *string* "LAN_2_0" in the database.

* Selecting "LAN [IPMI 1.5]" in the UI causes the "power_driver" setting
  to disappear from the power parameters stored in the database.

It's not the driver's fault the data is bad. Ideally it wouldn't be the
driver's responsibility to deal with this bad data, but pragmatically we
may want it to.

Likely next steps:

-> Update IPMI driver to deal with bad data and DTRT.

-> Fix validation of power parameters to avoid adding new bad data.

-> Fix existing power parameters in running MAAS installations.

Gavin Panella (allenap) wrote :

While we're fixing validation, we should also fix the whitespace issue identified in bug 1484551.

Gavin Panella (allenap) on 2015-09-02
Changed in maas:
status: New → Triaged
Gavin Panella (allenap) wrote :

This is fixed now, right?

Newell Jensen (newell-jensen) wrote :

Yes. All the new power driver code changes fixed this AFAIK.

Gavin Panella (allenap) on 2015-09-03
Changed in maas:
status: Triaged → Fix Committed
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers