utils.fs.atomic_write does not preserve file ownership
Bug #1443346 reported by
ubuntudotcom1
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Critical
|
ubuntudotcom1 | ||
Bug Description
The atomic_write operation in utils.fs.py does not preserve the uid / gid ownership attributes of the file. This bug was originally discovered during testing of the new configuration file backend (that uses atomic_write to update configuration files.)
Related branches
lp:~ubuntudotcom1/maas/bug-1443346-atomic-write-copy-ownership
- Gavin Panella (community): Approve
- Mike Pontillo (community): Approve
-
Diff: 106 lines (+44/-6)2 files modifiedsrc/provisioningserver/utils/fs.py (+18/-3)
src/provisioningserver/utils/tests/test_fs.py (+26/-3)
Revision history for this message
| Raphaël Badin (rvb) wrote | #1 |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| description: | updated |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
The fix for this has landed (and it seems it caused bug 1446840)… but it would be great to explain exactly why this bug was filed in the first place. I mean, it seems wrong not to preserve file ownership but it would be good to know the precise problem that caused this bug to be filed.