Conflicting timeouts for commissioning, perhaps other actions
Bug #1439945 reported by
Christian Reis
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
High
|
Unassigned |
Bug Description
A user is trying to change the commissioning time to be longer. I can see:
maasserver/
def get_commissioni
"""Return the commissioning time of this node (in seconds).
This is the maximum time the commissioning is allowed to take.
"""
# Return a *very* conservative estimate for now.
return timedelta(
but I can also see:
maas/settings.py:
# The duration, in minutes, after which we consider a commissioning node
# to have failed and mark it as FAILED_
COMMISSIONING
So which is it?
To post a comment you must log in.
It seems we have two ways in which a node can timeout:
a) the timeout can be automatic: i.e. a timer is started at the beginning of the commissioning and will both power down the node and mark it "commissioning failed" if it doesn't commission within 20 minutes.
b) one can call the nodes API 'check_ commissioning' to get all the nodes that have been commissioning for more than 60 minutes by default and mark them 'failed commissioning' (note that this won't power down the nodes).
It seems b) was added to cope with failing commissioning before a) was introduced as a more generic way to to handle timeouts (deployment has the same "automatic timeout" mechanism).
It seems to me that b) is deprecated and fairly useless: commission can be aborted if need be.