uprade from 1.5.4 to 1.7 overwrote my cluster name

[Jeff Lane ]

I had a working maas server with 1.5.4 on fully updated trusty. I upgraded that directly to 1.7.0-beta6 from the experimental PPA to confirm that boot resources are lost on upgrade.

I also just noticed that my cluster has been renamed to a non-helpful UUID.

Before, my cluser was named "Cluster Critical-MAAS" and when you did a "node-groups list" that name appeared in the cluster_name field.

After upgrading, cluster_name has been changed to "Cluster 503bc204-030e-40d9-9c80-7f6112e9a5e6" and there is no easy way to go back and determine what the cluster was (assuming I had named it something like "web-server cluster" or "hadoop systems" or whatever.

[Julian Edwards (julian-edwards)]

I've just recreated this, so triaging. Very odd.

[Julian Edwards (julian-edwards)]

I suspect it's something to do with NodeGroupDefineForm, which blindly overwrites the cluster_name if one is not supplied in the form data.

I'm still not sure why this form is getting invoked upon an upgrade, maybe it's something to do with the changed way in which clusters register in the region now.

Given that the model code for new() also does this defaulting of the name, I am going to remove this overriding behaviour from the form. The cluster_name can happily live as a blank field so I don't see the point of defaulting it and especially not overriding existing values.

[Julian Edwards (julian-edwards)]

Also FTR, the code that does this has been in MAAS since at least 2012.

[Jeff Lane  (bladernr)]

FWIW, I've only stumbled on this now as I've only ever really used 1.5.x up to this point. Before that, I had intermittent MAAS installs of other versions that were only short-lived. this time I have a full time 1.5.4 server and upgrading was done to test some of the 1.7 features, and that's when I stumbled on this.