The timeout for change_power_action() isn't configurable

Bug #1377904 reported by Graham Binns
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Invalid
Wishlist
Unassigned

Bug Description

As of r3197 there's been a timeout on calls to change_power_action() in provisioningserver.rpc.power. This is hard-coded to two minutes, after conversation with Dustin on IRC:

11:29 < gmb> rvba, jhobbs, kirkland: Realise you're in Brussels but… I'm looking to add a timeout to the code that runs power actions on nodes (as part of fixing https://bugs.launchpad.net/maas/+bug/1376782). Obviously this involves some guesswork (I don't know how long these things take to run on, say, IPMI nodes). Is 60 seconds too short? What about 5 minutes?
11:29 < gmb> allenap: Also would like your opinion on ^^
11:30 < kirkland> gmb: 2-5 minutes, I'd think, gmb
11:30 < kirkland> gmb: maybe expose it as a config option for the admin to twiddle?
11:30 < kirkland> gmb: with a sane default of 2m?
11:31 < gmb> kirkland: That'd be nice; for 1.7 I'll go with a sane default and maybe we can make it configurable in 1.7.1 (too many nasty bugs to fix to start adding new UI elements).
11:31 < kirkland> gmb: ack
11:31 < gmb> kirkland: Thanks for the advice.
11:32 < kirkland> gmb: let's set to 2m for 1.7, and make it configurable by the admin for another releas

Revision history for this message
Gavin Panella (allenap) wrote :

I think we should avoid having more knobs to twiddle. Apart from anything else it's another question to ask when a user needs help with power control: "What have you got the global power time-out set to? Oh, that's a bit low/high, try X...".

However, it may be useful to allow the power drivers to declare an overall time-out value. The AMT driver might want 5 minutes, whereas virsh might be happy with 1 minute.

Revision history for this message
Graham Binns (gmb) wrote : Re: [Bug 1377904] Re: The timeout for change_power_action() isn't configurable

On 6 October 2014 13:35, Gavin Panella <email address hidden> wrote:
>
> However, it may be useful to allow the power drivers to declare an
> overall time-out value. The AMT driver might want 5 minutes, whereas
> virsh might be happy with 1 minute.

That would be a nicer solution, for sure.

Revision history for this message
Julian Edwards (julian-edwards) wrote :

On Monday 06 Oct 2014 12:35:32 you wrote:
> I think we should avoid having more knobs to twiddle. Apart from
> anything else it's another question to ask when a user needs help with
> power control: "What have you got the global power time-out set to? Oh,
> that's a bit low/high, try X...".
>
> However, it may be useful to allow the power drivers to declare an
> overall time-out value. The AMT driver might want 5 minutes, whereas
> virsh might be happy with 1 minute.

This absolutely should come from the power drivers and not be a global config.

Changed in maas:
importance: High → Wishlist
milestone: none → next
Revision history for this message
Andres Rodriguez (andreserl) wrote :

Hi!

**This is an automated message**

We believe this is may no longer be an issue in the latest MAAS release. Due to the report date of this, we are currently marking it as Invalid. If you believe this bug report still valid against the latest release of MAAS, or if you are still interested in this, please re-open this bug report.

Thanks

Changed in maas:
status: Triaged → Invalid
Changed in maas:
milestone: next → none
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.