Unreliable tests related to query counting
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
MAAS |
Fix Released
|
High
|
Blake Rouse |
Bug Description
Something today, 2014-10-03, appears to have caused several tests to become unreliable:
maasserver.
maasserver.
maasserver.
I noticed the problem when trying to land https:/
I will be disabling these tests and marking them with XXX referencing this bug.
Related branches
- Mike Pontillo (community): Approve
-
Diff: 850 lines (+336/-127)19 files modifiedHACKING.txt (+15/-0)
src/maasserver/__init__.py (+2/-6)
src/maasserver/api/blockdevices.py (+7/-11)
src/maasserver/api/machines.py (+37/-2)
src/maasserver/api/nodes.py (+50/-7)
src/maasserver/api/tests/test_enlistment.py (+2/-0)
src/maasserver/api/tests/test_machines.py (+23/-6)
src/maasserver/api/tests/test_nodes.py (+0/-28)
src/maasserver/apps.py (+14/-0)
src/maasserver/models/blockdevice.py (+5/-1)
src/maasserver/models/domain.py (+5/-7)
src/maasserver/models/fabric.py (+2/-1)
src/maasserver/models/interface.py (+18/-15)
src/maasserver/models/node.py (+57/-31)
src/maasserver/models/partitiontable.py (+5/-5)
src/maasserver/monkey.py (+41/-2)
src/maasserver/plugin.py (+0/-4)
src/maasserver/testing/fixtures.py (+52/-0)
src/maasserver/utils/storage.py (+1/-1)
Changed in maas: | |
milestone: | none → 2.2.0rc3 |
assignee: | nobody → Blake Rouse (blake-rouse) |
status: | Triaged → In Progress |
Changed in maas: | |
status: | In Progress → Fix Committed |
Changed in maas: | |
status: | Fix Committed → Fix Released |
On Friday, 3 October 2014, Gavin Panella <email address hidden>
wrote:
> Public bug reported: views.tests. test_nodes. NodeViewsTest. test_node_ list_num_ queries_ is_independent_ of_num_ nodes views.tests. test_tags. TagViewsTest. test_view_ tag_num_ queries_ is_independent_ of_num_ nodes api.tests. test_nodes. TestNodesAPI. test_GET_ list_nodes_ issues_ constant_ number_ of_queries
>
> Something today, 2014-10-03, appears to have caused several tests to
> become unreliable:
>
>
> maasserver.
>
> maasserver.
>
> maasserver.
>
I fear this might have been caused by my branch to add alerts when clusters
are disconnected; I saw this failure when I tried to land the branch, but
couldn't reproduce it locally (and it landed on the second attempt anyway).
Of course, it could be that there was already something going weird and I,
like you, am only seeing it thanks to cosmic providence.
The reason I suspect my branch is that it adds an extra query — fetching
all accepted clusters — to each request. Why that doesn't have a consistent
effect I don't know (I was too jetlagged to dig around and then hey! the
problem went away!).
Anyway, just thoughts. Can't test them right now, but maybe someone else
can.