Elusive JavaScript lint

[Jeroen T. Vermeulen]

This has been confounding us for ages now: sometimes our lint checks report lint in our JavaScript, sometimes they don't.

Here's the lint I just saw reported in trunk r3185:

«
./src/maasserver/static/js/image_views.js
      70: Expected ';' and instead saw 'this'.
     191: Expected '===' and instead saw '=='.
     195: Expected ';' and instead saw '}'.
     197: Expected ';' and instead saw '}'.
     223: Expected ';' and instead saw 'if'.
     244: Expected '{' and instead saw 'this'.
     246: Expected '{' and instead saw 'this'.
     249: Expected '{' and instead saw 'this'.
     251: Expected '{' and instead saw 'this'.
     254: Expected '===' and instead saw '=='.
./src/maasserver/static/js/tests/test_image_views.js
     183: Unexpected ','.
     196: Unexpected ','.
     209: Unexpected ','.
     210: Unexpected ','.
     330: Unexpected ','.
     335: Unexpected ','.
»

Some of this looks like it may affect browser compatibility — definitely the ones in the test.

[Jeroen T. Vermeulen (jtv)]

Turns out you get these extra lint checks if you have gjs installed.