MAAS

Spurious test failure: TestBootSource.test_calls_cache_boot_sources_on_create

Bug #1376317 reported by Jeroen T. Vermeulen
18
This bug affects 3 people
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
High
Blake Rouse
MAAS 2.0.0

Bug Description

This test fails about 1% of the time:

«
FAIL: maasserver.models.tests.test_bootsource.TestBootSource.test_calls_cache_boot_sources_on_create
----------------------------------------------------------------------
_StringException: Traceback (most recent call last):
  File "/tmp/tarmac/branch.e8IbUj/src/maasserver/models/tests/test_bootsource.py", line 107, in test_calls_cache_boot_sources_on_create
    MockCalledOnceWith(1, deferToThread, _cache_boot_sources))
  File "/usr/lib/python2.7/dist-packages/testtools/testcase.py", line 406, in assertThat
    raise mismatch_error
MismatchError: Expected to be called once. Called 2 times.
»

Related branches

lp:~allenap/maas/spurious-boot-source-test-failures
Gavin Panella (community): Approve
Diff: 21 lines (+4/-0)
1 file modified
src/maasserver/models/tests/test_bootsource.py (+4/-0)
lp:~blake-rouse/maas/fix-images-cache-and-import
Andres Rodriguez (community): Approve
Diff: 1448 lines (+291/-323)
26 files modified
src/maasserver/api/tests/test_boot_source_selections.py (+7/-3)
src/maasserver/api/tests/test_boot_sources.py (+7/-3)
src/maasserver/bootresources.py (+25/-41)
src/maasserver/bootsources.py (+1/-1)
src/maasserver/clusterrpc/tests/test_boot_images.py (+9/-0)
src/maasserver/migrations/builtin/maasserver/0061_maas_nodegroup_worker_to_maas.py (+1/-1)
src/maasserver/migrations/builtin/maasserver/0062_fix_bootsource_daily_label.py (+27/-0)
src/maasserver/models/signals/bootsources.py (+8/-2)
src/maasserver/models/signals/tests/test_bootsources.py (+55/-0)
src/maasserver/models/testing.py (+0/-15)
src/maasserver/models/tests/test_bootresource.py (+4/-2)
src/maasserver/models/tests/test_bootsource.py (+4/-30)
src/maasserver/models/tests/test_bootsourcecache.py (+4/-2)
src/maasserver/models/tests/test_bootsourceselection.py (+4/-2)
src/maasserver/rpc/tests/test_configuration.py (+13/-0)
src/maasserver/rpc/tests/test_regionservice_calls.py (+9/-0)
src/maasserver/start_up.py (+1/-74)
src/maasserver/tests/test_bootresources.py (+31/-53)
src/maasserver/tests/test_bootsources.py (+16/-6)
src/maasserver/tests/test_compose_preseed.py (+9/-0)
src/maasserver/tests/test_forms_bootsource.py (+4/-2)
src/maasserver/tests/test_forms_bootsourceselection.py (+4/-2)
src/maasserver/tests/test_service_monitor.py (+17/-0)
src/maasserver/tests/test_start_up.py (+11/-77)
src/maasserver/views/tests/test_images.py (+7/-3)
src/maasserver/views/tests/test_settings.py (+13/-4)
Julian Edwards (julian-edwards)
tags: added: tech-debt
Revision history for this message
Gavin Panella (allenap) wrote :

This has prevented landing in https://code.launchpad.net/~allenap/maas/boot-resources-service-crashing--1.7/+merge/239854 so I'm disabling it.

Revision history for this message
Gavin Panella (allenap) wrote :

I should have said I'm disabling it in 1.7 only.

Revision history for this message
Gavin Panella (allenap) wrote :

I'm also disabling it in trunk.

Blake Rouse (blake-rouse)
Changed in maas:
status: Triaged → In Progress
milestone: none → 2.0.0
assignee: nobody → Blake Rouse (blake-rouse)
MAAS Lander (maas-lander)
Changed in maas:
status: In Progress → Fix Committed
Andres Rodriguez (andreserl)
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.