boot-source-selections api allows adding bogus and duplicated values

[Diogo Matsubara]

Not sure if this is by design or what are the specific consequences of this but one can add duplicated boot source entries in the MAAS db if one runs the following command multiple times:

maas maas boot-source-selections create 1ed50935-a572-4542-8db5-9be4f6fab764 1 release=utopic labels=daily arches=* subarches=*

and get:

    {
        "labels": [
            "daily"
        ],
        "arches": [
            "*"
        ],
        "subarches": [
            "*"
        ],
        "release": "utopic",
        "id": 5,
        "resource_uri": "/MAAS/api/1.0/nodegroups/1ed50935-a572-4542-8db5-9be4f6fab764/boot-sources/1/selections/5/"
    },
    {
        "labels": [
            "daily"
        ],
        "arches": [
            "*"
        ],
        "subarches": [
            "*"
        ],
        "release": "utopic",
        "id": 6,
        "resource_uri": "/MAAS/api/1.0/nodegroups/1ed50935-a572-4542-8db5-9be4f6fab764/boot-sources/1/selections/6/"
    }

Or if one runs:

maas maas boot-source-selections create 1ed50935-a572-4542-8db5-9be4f6fab764 1

the db ends up with an empty entry like:

    {
        "labels": [],
        "arches": [],
        "subarches": [],
        "release": "",
        "id": 3,
        "resource_uri": "/MAAS/api/1.0/nodegroups/1ed50935-a572-4542-8db5-9be4f6fab764/boot-sources/1/selections/3/"
    },

[Blake Rouse (blake-rouse)]

No it is not by design. It is incorrect.

[Blake Rouse (blake-rouse)]

This can now use the BootSourceCache to check if the values are correct for the given resource.

[Christian Reis (kiko)]

Blake, is this not a dupe of bug 1376812?