deprecate use-fastpath-installer tag and use a property on node instead

Bug #1343425 reported by Blake Rouse
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Fix Released
High
Blake Rouse

Bug Description

Currently a tag is used to identify that a node should boot using fastpath installer. To support other booting methods, this makes it really difficult to understand what booting method will be used.

Below is a comment from Julian on why this needs to occur:

Using tags is very poor taste for settings like this, the original
implementation was extremely lazy in its approach IMO. And now you can
see the problem - what should happen if both tags are defined because
there was a problem adding one and removing the other?

What we should be doing is turning this all into a API calls
"set_boot_type_XXX" or similar, which handles the internals gracefully.
 Because right now, we're exposing its implementation details (the tags)
directly to the user. That violates just about every law of software
layering ever thought of.

In summary:

 - deprecate the tag, and add a new ENUM property on the node to select
boot_type (this could just encapsulate tags but ideally a DB column)
 - add API functions to set the boot type, e.g.
   - set_boot_type_fast
   - set_boot_type_diskless
   - set_boot_type_debian_installer

Cheers,
J

Related branches

Changed in maas:
status: In Progress → Fix Committed
Changed in maas:
milestone: none → 1.7.0
Changed in maas:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.