When stopping a node from the web UI that was started from the API, distro_series is not cleared

Bug #1316396 reported by Julian Edwards on 2014-05-06
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MAAS
Critical
Julian Edwards
1.5
Critical
Julian Edwards
maas (Ubuntu)
Undecided
Unassigned
Trusty
Undecided
Unassigned

Bug Description

[Test Case]
1. Install MAAS
2. Add a node.
3. Deploy the node
4. When you destroy a node, distro_series will remain with the selected distro_series.

With the fix:
4. When you destroy a node, distro_series will be cleared.

I'm not sure how I got into this state, but one of my nodes that's unallocated has a valid value in its distro_series field. This means that when you start it up from the web UI next time it will now ignore the global default and always use that series because of the logic in Node.get_distro_series().

At the very least, Node.release() should call set_distro_series(series=''). For some odd reason, this is only called from the API release() method rather than the common Node method.

UPDATE:
It had been originally started with the API (which sets the passed distro series) but released with the web UI.

Related branches

Changed in maas:
status: New → Triaged
importance: Undecided → Critical
assignee: nobody → Julian Edwards (julian-edwards)
summary: - When stopping a node from the web UI, distro_series is not cleared
+ When stopping a node from the web UI that was started from the API,
+ distro_series is not cleared
description: updated
Changed in maas:
status: Triaged → Fix Committed
description: updated
Changed in maas:
status: Fix Committed → Fix Released
Chris J Arges (arges) on 2014-05-09
Changed in maas (Ubuntu):
status: New → Fix Released

Hello Julian, or anyone else affected,

Accepted maas into trusty-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/maas/1.5.1+bzr2269-0ubuntu0.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in maas (Ubuntu Trusty):
status: New → Fix Committed
tags: added: verification-needed
tags: added: verification-done
removed: verification-needed
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package maas - 1.5.1+bzr2269-0ubuntu0.1

---------------
maas (1.5.1+bzr2269-0ubuntu0.1) trusty; urgency=medium

  * Stable Release Update (LP: #1317601):
    - Hardware Enablement for Cisco B-Series. (LP: #1300476)
    - Allow AMT power type to specify IP Address. (LP: #1308772)
    - Spurious failure when starting and creating lock files. (LP: 1308069)
    - Fix usage of hardware enablement kernels by fixing the preseeds
      (LP: #1310082, LP: #1310076, LP: #1310082)
    - Fix parallel juju deployments. (LP: #1314409)
    - Clear distro_series when stopping node from WebUI (LP: #1316396)
    - Fix click hijacking (LP: #1298784)
    - Fix blocking API client when deleting a resource (LP: #1313556)
    - Do not import Trusty RC images by default (LP: #1311151)
    - debian/control: Add missing dep on python-crochet for
      python-maas-provisioningserver (LP: #1311765)
 -- Andres Rodriguez <email address hidden> Fri, 09 May 2014 22:35:43 -0500

Changed in maas (Ubuntu Trusty):
status: Fix Committed → Fix Released

The verification of the Stable Release Update for maas has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers