Broadcast address is required on cluster form
Bug #1299374 reported by
Jeroen T. Vermeulen
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
Low
|
Jeroen T. Vermeulen | ||
Bug Description
When creating or editing a managed cluster interface, an admin is required to enter a broadcast address. In this day and age there really shouldn't be any need for that. We know the netmask, we know the network address, and the broadcast address follows automatically. The field could be left out, or automatically pre-populated, or as a simple compromise, moved to the bottom and made optional (with the obvious value being computed at run time).
Related branches
lp:~jtv/maas/bug-1299374
- Julian Edwards (community): Approve
-
Diff: 303 lines (+75/-58)4 files modifiedsrc/maasserver/models/nodegroup.py (+2/-2)
src/maasserver/models/nodegroupinterface.py (+29/-30)
src/maasserver/models/tests/test_nodegroupinterface.py (+42/-25)
src/maasserver/rpc/tests/test_regionservice.py (+2/-1)
Revision history for this message
| Jeroen T. Vermeulen (jtv) wrote | #1 |
| Changed in maas: | |
| status: | Triaged → Fix Committed |
| Changed in maas: | |
| assignee: | nobody → Jeroen T. Vermeulen (jtv) |
| milestone: | none → 14.04 |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
The code uses the broadcast address (which is optional), not the interface's IP address (which is required), to define the network's address. Why!? I see no comment, and I'm fairly sure the IP address wasn't added later.
To make things even more confusing, model validation does require that the interface's IP address be in the same network. So there is no situation where the broadcast address might have information that we need and can't get from the IP address. I think we can just derive the full network spec from IP address and netmask, and make the broadcast address optional.